diff mbox series

[net,3/6] net/mlx5e: Remove warning "devices are not on same switch HW"

Message ID 20200529065645.118386-4-saeedm@mellanox.com
State Changes Requested
Delegated to: David Miller
Headers show
Series [net,1/6] net/mlx5: Fix crash upon suspend/resume | expand

Commit Message

Saeed Mahameed May 29, 2020, 6:56 a.m. UTC 
From: Maor Dickman <maord@mellanox.com>

On tunnel decap rule insertion, the indirect mechanism will attempt to
offload the rule on all uplink representors which will trigger the
"devices are not on same switch HW, can't offload forwarding" message
for the uplink which isn't on the same switch HW as the VF representor.

The above flow is valid and shouldn't cause warning message,
fix by removing the warning and only report this flow using extack.

Fixes: f3953003a66f ("net/mlx5e: Fix allowed tc redirect merged eswitch offload cases")
Signed-off-by: Maor Dickman <maord@mellanox.com>
Reviewed-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Jakub Kicinski May 29, 2020, 7:12 p.m. UTC | #1 
On Thu, 28 May 2020 23:56:42 -0700 Saeed Mahameed wrote:
> From: Maor Dickman <maord@mellanox.com>
> 
> On tunnel decap rule insertion, the indirect mechanism will attempt to
> offload the rule on all uplink representors which will trigger the
> "devices are not on same switch HW, can't offload forwarding" message
> for the uplink which isn't on the same switch HW as the VF representor.
> 
> The above flow is valid and shouldn't cause warning message,
> fix by removing the warning and only report this flow using extack.
> 
> Fixes: f3953003a66f ("net/mlx5e: Fix allowed tc redirect merged eswitch offload cases")
> Signed-off-by: Maor Dickman <maord@mellanox.com>
> Reviewed-by: Roi Dayan <roid@mellanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

Fixes tag: Fixes: f3953003a66f ("net/mlx5e: Fix allowed tc redirect merged eswitch offload cases")
Has these problem(s):
	- Target SHA1 does not exist
Saeed Mahameed May 29, 2020, 8 p.m. UTC | #2 
On Fri, 2020-05-29 at 12:12 -0700, Jakub Kicinski wrote:
> On Thu, 28 May 2020 23:56:42 -0700 Saeed Mahameed wrote:
> > From: Maor Dickman <maord@mellanox.com>
> > 
> > On tunnel decap rule insertion, the indirect mechanism will attempt
> > to
> > offload the rule on all uplink representors which will trigger the
> > "devices are not on same switch HW, can't offload forwarding"
> > message
> > for the uplink which isn't on the same switch HW as the VF
> > representor.
> > 
> > The above flow is valid and shouldn't cause warning message,
> > fix by removing the warning and only report this flow using extack.
> > 
> > Fixes: f3953003a66f ("net/mlx5e: Fix allowed tc redirect merged
> > eswitch offload cases")
> > Signed-off-by: Maor Dickman <maord@mellanox.com>
> > Reviewed-by: Roi Dayan <roid@mellanox.com>
> > Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
> 
> Fixes tag: Fixes: f3953003a66f ("net/mlx5e: Fix allowed tc redirect
> merged eswitch offload cases")
> Has these problem(s):
> 	- Target SHA1 does not exist

Fixing, thanks !
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index cac36c27c7fa4..6e7b2ce29d411 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -3849,10 +3849,6 @@  static int parse_tc_fdb_actions(struct mlx5e_priv *priv,
 				if (!mlx5e_is_valid_eswitch_fwd_dev(priv, out_dev)) {
 					NL_SET_ERR_MSG_MOD(extack,
 							   "devices are not on same switch HW, can't offload forwarding");
-					netdev_warn(priv->netdev,
-						    "devices %s %s not on same switch HW, can't offload forwarding\n",
-						    priv->netdev->name,
-						    out_dev->name);
 					return -EOPNOTSUPP;
 				}