[net-next,v5,4/9] igc: Use netdev log helpers in igc_ethtool.c

From: Andre Guedes <andre.guedes@intel.com>

In igc_ethtool.c we print log messages using dev_* helpers, generating
inconsistent output with the rest of the driver. Since this is a network
device driver, we should preferably use netdev_* helpers because they
append the interface name to the message, helping making sense the of
the logs.

This patch converts all dev_* calls to netdev_*.

Signed-off-by: Andre Guedes <andre.guedes@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/igc/igc_ethtool.c | 41 ++++++++++----------
 1 file changed, 21 insertions(+), 20 deletions(-)

On Mon, 2020-05-18 at 18:03 -0700, Jeff Kirsher wrote:
> This patch converts all dev_* calls to netdev_*.
[]
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
[]
> @@ -1904,7 +1905,7 @@ static void igc_diag_test(struct net_device *netdev,
>  	bool if_running = netif_running(netdev);
>  
>  	if (eth_test->flags == ETH_TEST_FL_OFFLINE) {
> -		netdev_info(adapter->netdev, "offline testing starting");
> +		netdev_info(adapter->netdev, "Offline testing starting");

several missing '\n' format terminations

		netdev_info(adapter->netdev, "Offline testing starting\n");

>  		set_bit(__IGC_TESTING, &adapter->state);
>  
>  		/* Link test performed before hardware reset so autoneg doesn't
> @@ -1918,13 +1919,13 @@ static void igc_diag_test(struct net_device *netdev,
>  		else
>  			igc_reset(adapter);
>  
> -		netdev_info(adapter->netdev, "register testing starting");
> +		netdev_info(adapter->netdev, "Register testing starting");

etc...

> -----Original Message-----
> From: Joe Perches <joe@perches.com>
> Sent: Monday, May 18, 2020 18:22
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; davem@davemloft.net
> Cc: Guedes, Andre <andre.guedes@intel.com>; netdev@vger.kernel.org;
> nhorman@redhat.com; sassmann@redhat.com; Brown, Aaron F
> <aaron.f.brown@intel.com>
> Subject: Re: [net-next v5 4/9] igc: Use netdev log helpers in igc_ethtool.c
> 
> On Mon, 2020-05-18 at 18:03 -0700, Jeff Kirsher wrote:
> > This patch converts all dev_* calls to netdev_*.
> []
> > diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> > b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> []
> > @@ -1904,7 +1905,7 @@ static void igc_diag_test(struct net_device
> *netdev,
> >  	bool if_running = netif_running(netdev);
> >
> >  	if (eth_test->flags == ETH_TEST_FL_OFFLINE) {
> > -		netdev_info(adapter->netdev, "offline testing starting");
> > +		netdev_info(adapter->netdev, "Offline testing starting");
> 
> several missing '\n' format terminations
[Kirsher, Jeffrey T] 

Your right, these never had them, which is why it was not caught.  I am fine with adding the terminating \n, if that is what is requested.  Andre was just trying to fix the message to properly capitalize the first letter of the message.

> 
> 		netdev_info(adapter->netdev, "Offline testing starting\n");
> 
> >  		set_bit(__IGC_TESTING, &adapter->state);
> >
> >  		/* Link test performed before hardware reset so autoneg doesn't
> @@
> > -1918,13 +1919,13 @@ static void igc_diag_test(struct net_device *netdev,
> >  		else
> >  			igc_reset(adapter);
> >
> > -		netdev_info(adapter->netdev, "register testing starting");
> > +		netdev_info(adapter->netdev, "Register testing starting");
> 
> etc...
[Kirsher, Jeffrey T] 

Yep here too

On Tue, 2020-05-19 at 01:35 +0000, Kirsher, Jeffrey T wrote:
> > -----Original Message-----
> > From: Joe Perches <joe@perches.com>
> > Sent: Monday, May 18, 2020 18:22
> > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; davem@davemloft.net
> > Cc: Guedes, Andre <andre.guedes@intel.com>; netdev@vger.kernel.org;
> > nhorman@redhat.com; sassmann@redhat.com; Brown, Aaron F
> > <aaron.f.brown@intel.com>
> > Subject: Re: [net-next v5 4/9] igc: Use netdev log helpers in igc_ethtool.c
> > 
> > On Mon, 2020-05-18 at 18:03 -0700, Jeff Kirsher wrote:
> > > This patch converts all dev_* calls to netdev_*.
> > []
> > > diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> > > b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> > []
> > > @@ -1904,7 +1905,7 @@ static void igc_diag_test(struct net_device
> > *netdev,
> > >  	bool if_running = netif_running(netdev);
> > > 
> > >  	if (eth_test->flags == ETH_TEST_FL_OFFLINE) {
> > > -		netdev_info(adapter->netdev, "offline testing starting");
> > > +		netdev_info(adapter->netdev, "Offline testing starting");
> > 
> > several missing '\n' format terminations
> [Kirsher, Jeffrey T] 
> 
> Your right, these never had them, which is why it was not caught.
> I am fine with adding the terminating \n, if that is what is requested.
> Andre was just trying to fix the message to properly capitalize the first letter of the message.

What's odd is no other intel driver uses the same logging
format even though many use the same message.

Likely there's little value in capitalization.

$ git grep -i -n "offline testing starting" drivers/net/ethernet/intel
drivers/net/ethernet/intel/e1000/e1000_ethtool.c:1524:          e_info(hw, "offline testing starting\n");
drivers/net/ethernet/intel/e1000e/ethtool.c:1818:               e_info("offline testing starting\n");
drivers/net/ethernet/intel/i40e/i40e_ethtool.c:2536:            netif_info(pf, drv, netdev, "offline testing starting\n");
drivers/net/ethernet/intel/ice/ice_ethtool.c:807:               netdev_info(netdev, "offline testing starting\n");
drivers/net/ethernet/intel/igb/igb_ethtool.c:2025:              dev_info(&adapter->pdev->dev, "offline testing starting\n");
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c:2095:          e_info(hw, "offline testing starting\n");
drivers/net/ethernet/intel/ixgbevf/ethtool.c:744:               hw_dbg(&adapter->hw, "offline testing starting\n");