diff mbox series

[net] net: phy: propagate an error back to the callers of phy_sfp_probe

Message ID 20200517115340.78554-1-leon@kernel.org
State Accepted
Delegated to: David Miller
Headers show
Series [net] net: phy: propagate an error back to the callers of phy_sfp_probe | expand

Commit Message

Leon Romanovsky May 17, 2020, 11:53 a.m. UTC
From: Leon Romanovsky <leonro@mellanox.com>

The compilation warning below reveals that the errors returned from
the sfp_bus_add_upstream() call are not propagated to the callers.
Fix it by returning "ret".

14:37:51 drivers/net/phy/phy_device.c: In function 'phy_sfp_probe':
14:37:51 drivers/net/phy/phy_device.c:1236:6: warning: variable 'ret'
   set but not used [-Wunused-but-set-variable]
14:37:51  1236 |  int ret;
14:37:51       |      ^~~

Fixes: 298e54fa810e ("net: phy: add core phylib sfp support")
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
 drivers/net/phy/phy_device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.26.2

Comments

David Miller May 17, 2020, 7:44 p.m. UTC | #1
From: Leon Romanovsky <leon@kernel.org>
Date: Sun, 17 May 2020 14:53:40 +0300

> From: Leon Romanovsky <leonro@mellanox.com>
> 
> The compilation warning below reveals that the errors returned from
> the sfp_bus_add_upstream() call are not propagated to the callers.
> Fix it by returning "ret".
> 
> 14:37:51 drivers/net/phy/phy_device.c: In function 'phy_sfp_probe':
> 14:37:51 drivers/net/phy/phy_device.c:1236:6: warning: variable 'ret'
>    set but not used [-Wunused-but-set-variable]
> 14:37:51  1236 |  int ret;
> 14:37:51       |      ^~~
> 
> Fixes: 298e54fa810e ("net: phy: add core phylib sfp support")
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index ac2784192472..697c74deb222 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1233,7 +1233,7 @@  int phy_sfp_probe(struct phy_device *phydev,
 		  const struct sfp_upstream_ops *ops)
 {
 	struct sfp_bus *bus;
-	int ret;
+	int ret = 0;

 	if (phydev->mdio.dev.fwnode) {
 		bus = sfp_bus_find_fwnode(phydev->mdio.dev.fwnode);
@@ -1245,7 +1245,7 @@  int phy_sfp_probe(struct phy_device *phydev,
 		ret = sfp_bus_add_upstream(bus, phydev, ops);
 		sfp_bus_put(bus);
 	}
-	return 0;
+	return ret;
 }
 EXPORT_SYMBOL(phy_sfp_probe);