| Message ID | 20200514165938.21725-1-brgl@bgdev.pl |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: phy: mdio-moxart: remove unneeded include | expand |
On Thu, May 14, 2020 at 06:59:38PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > mdio-moxart doesn't use regulators in the driver code. We can remove > the regulator include. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 5/14/2020 9:59 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > mdio-moxart doesn't use regulators in the driver code. We can remove > the regulator include. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
czw., 14 maj 2020 o 19:13 Florian Fainelli <f.fainelli@gmail.com> napisał(a): > > > > On 5/14/2020 9:59 AM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > mdio-moxart doesn't use regulators in the driver code. We can remove > > the regulator include. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > -- > Florian Hi Andrew, Florian, I noticed this by accident when I was looking at the PHY drivers to see how they handle regulators supplying PHYs. In the case of the MediaTek Pumpkin board I'm working on - the PHY is a Realtek RTL8201F and it's supplied by a regulator that's enabled on boot by the relevant PMIC driver. I'd like to model it in the device-tree but I'm not sure what the correct approach is. Some ethernet drivers have a phy-supply property but it looks wrong to me - IMO this should be handled at the PHY driver level. Is it fine if I add a probe() callback to the realtek driver and retrieve the "phy-supply" there? Bart
On 5/14/2020 10:20 AM, Bartosz Golaszewski wrote: > czw., 14 maj 2020 o 19:13 Florian Fainelli <f.fainelli@gmail.com> napisał(a): >> >> >> >> On 5/14/2020 9:59 AM, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski <bgolaszewski@baylibre.com> >>> >>> mdio-moxart doesn't use regulators in the driver code. We can remove >>> the regulator include. >>> >>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> >> >> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> >> -- >> Florian > > Hi Andrew, Florian, > > I noticed this by accident when I was looking at the PHY drivers to > see how they handle regulators supplying PHYs. In the case of the > MediaTek Pumpkin board I'm working on - the PHY is a Realtek RTL8201F > and it's supplied by a regulator that's enabled on boot by the > relevant PMIC driver. I'd like to model it in the device-tree but I'm > not sure what the correct approach is. Some ethernet drivers have a > phy-supply property but it looks wrong to me - IMO this should be > handled at the PHY driver level. Is it fine if I add a probe() > callback to the realtek driver and retrieve the "phy-supply" there? Don't you need to do this earlier than probe() though? If the PHY device is powered down, then surely get_phy_id() won't be able to read its registers and bind the device to the driver. This should be dealt the same way that resets are being dealt with, which is prior to the MDIO bus scan.
From: Bartosz Golaszewski <brgl@bgdev.pl> Date: Thu, 14 May 2020 18:59:38 +0200 > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > mdio-moxart doesn't use regulators in the driver code. We can remove > the regulator include. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Applied to net-next.
diff --git a/drivers/net/phy/mdio-moxart.c b/drivers/net/phy/mdio-moxart.c index 2d16fc4173c1..b72c6d185175 100644 --- a/drivers/net/phy/mdio-moxart.c +++ b/drivers/net/phy/mdio-moxart.c @@ -12,7 +12,6 @@ #include <linux/of_mdio.h> #include <linux/phy.h> #include <linux/platform_device.h> -#include <linux/regulator/consumer.h> #define REG_PHY_CTRL 0 #define REG_PHY_WRITE_DATA 4