| Message ID | 20200430175759.1301789-4-kuba@kernel.org |
|---|---|
| State | Superseded |
| Delegated to: | David Miller |
| Headers | show |
| Series | devlink: kernel region snapshot id allocation | expand |
Thu, Apr 30, 2020 at 07:57:58PM CEST, kuba@kernel.org wrote: >In past discussions Jiri explained snapshot ids are cross-region. >Explain this in the docs. > >v3: new patch > >Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
On 4/30/2020 10:57 AM, Jakub Kicinski wrote: > In past discussions Jiri explained snapshot ids are cross-region. > Explain this in the docs. > > v3: new patch > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
diff --git a/Documentation/networking/devlink/devlink-region.rst b/Documentation/networking/devlink/devlink-region.rst index daf35427fce1..3654c3e9658f 100644 --- a/Documentation/networking/devlink/devlink-region.rst +++ b/Documentation/networking/devlink/devlink-region.rst @@ -14,6 +14,10 @@ Region snapshots are collected by the driver, and can be accessed via read or dump commands. This allows future analysis on the created snapshots. Regions may optionally support triggering snapshots on demand. +Snapshot identifiers are scoped to the devlink instance, not a region. +All snapshots with the same snapshot id within a devlink instance +correspond to the same event. + The major benefit to creating a region is to provide access to internal address regions that are otherwise inaccessible to the user.
In past discussions Jiri explained snapshot ids are cross-region. Explain this in the docs. v3: new patch Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- Documentation/networking/devlink/devlink-region.rst | 4 ++++ 1 file changed, 4 insertions(+)