diff mbox series

net: systemport: Omit superfluous error message in bcm_sysport_probe()

Message ID 20200418085105.12584-1-tangbin@cmss.chinamobile.com
State Accepted
Delegated to: David Miller
Headers show
Series net: systemport: Omit superfluous error message in bcm_sysport_probe() | expand

Commit Message

Tang Bin April 18, 2020, 8:51 a.m. UTC
In the function bcm_sysport_probe(), when get irq failed, the function
platform_get_irq() logs an error message, so remove redundant message
here.

Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
 drivers/net/ethernet/broadcom/bcmsysport.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Florian Fainelli April 18, 2020, 3:51 p.m. UTC | #1
On 4/18/2020 1:51 AM, Tang Bin wrote:
> In the function bcm_sysport_probe(), when get irq failed, the function
> platform_get_irq() logs an error message, so remove redundant message
> here.
> 
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
David Miller April 20, 2020, 6:05 p.m. UTC | #2
From: Tang Bin <tangbin@cmss.chinamobile.com>
Date: Sat, 18 Apr 2020 16:51:06 +0800

> In the function bcm_sysport_probe(), when get irq failed, the function
> platform_get_irq() logs an error message, so remove redundant message
> here.
> 
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index af7ce5c54..c99e5a3fa 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -2475,7 +2475,6 @@  static int bcm_sysport_probe(struct platform_device *pdev)
 		priv->wol_irq = platform_get_irq(pdev, 1);
 	}
 	if (priv->irq0 <= 0 || (priv->irq1 <= 0 && !priv->is_lite)) {
-		dev_err(&pdev->dev, "invalid interrupts\n");
 		ret = -EINVAL;
 		goto err_free_netdev;
 	}