| Message ID | 20200414181012.114905-2-robert.marko@sartura.hr |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v2,1/3] net: phy: mdio: add IPQ40xx MDIO driver | expand |
On 4/14/2020 11:10 AM, Robert Marko wrote: > This patch adds the binding document for the IPQ40xx MDIO driver. > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > Cc: Luka Perkov <luka.perkov@sartura.hr> > --- [snip] > +examples: > + - | > + mdio@90000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "qcom,ipq40xx-mdio"; > + reg = <0x90000 0x64>; > + status = "disabled"; I believe the preference is to not put status properties in examples. Other than that: Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
On Tue, Apr 14, 2020 at 11:11 PM Florian Fainelli <f.fainelli@gmail.com> wrote: > > > > On 4/14/2020 11:10 AM, Robert Marko wrote: > > This patch adds the binding document for the IPQ40xx MDIO driver. > > > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > > Cc: Luka Perkov <luka.perkov@sartura.hr> > > --- > > [snip] > > > +examples: > > + - | > > + mdio@90000 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + compatible = "qcom,ipq40xx-mdio"; > > + reg = <0x90000 0x64>; > > + status = "disabled"; > > I believe the preference is to not put status properties in examples. > Other than that: Will be changed in v3. Thanks > > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > -- > Florian
diff --git a/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml new file mode 100644 index 000000000000..3e2ccf417fb6 --- /dev/null +++ b/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/qcom,ipq40xx-mdio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm IPQ40xx MDIO Controller Device Tree Bindings + +maintainers: + - Robert Marko <robert.marko@sartura.hr> + +allOf: + - $ref: "mdio.yaml#" + +properties: + compatible: + const: qcom,ipq40xx-mdio + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + reg: + maxItems: 1 + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + +examples: + - | + mdio@90000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "qcom,ipq40xx-mdio"; + reg = <0x90000 0x64>; + status = "disabled"; + + ethphy0: ethernet-phy@0 { + reg = <0>; + }; + + ethphy1: ethernet-phy@1 { + reg = <1>; + }; + + ethphy2: ethernet-phy@2 { + reg = <2>; + }; + + ethphy3: ethernet-phy@3 { + reg = <3>; + }; + + ethphy4: ethernet-phy@4 { + reg = <4>; + }; + };
This patch adds the binding document for the IPQ40xx MDIO driver. Signed-off-by: Robert Marko <robert.marko@sartura.hr> Cc: Luka Perkov <luka.perkov@sartura.hr> --- .../bindings/net/qcom,ipq40xx-mdio.yaml | 62 +++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml