diff mbox series

[RFC,v1,43/50] drivers/isdn: Use get_random_u32()

Message ID 202003281643.02SGhN8L003837@sdf.org
State Not Applicable
Delegated to: David Miller
Headers show
Series None | expand

Commit Message

George Spelvin Aug. 22, 2019, 12:15 a.m. UTC
There's no need to get_random_bytes() into a temporary buffer.

This is not a no-brainer change; get_random_u32() has slightly weaker
security guarantees, but they're fine for applications like these where
the random value is stored in the kernel for as long as it's

Signed-off-by: George Spelvin <lkml@sdf.org>
Cc: Karsten Keil <isdn@linux-pingi.de>
Cc: isdn4linux@listserv.isdn4linux.de
Cc: netdev@vger.kernel.org
 drivers/isdn/mISDN/tei.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff mbox series


diff --git a/drivers/isdn/mISDN/tei.c b/drivers/isdn/mISDN/tei.c
index 59d28cb19738e..8135e20a667cc 100644
--- a/drivers/isdn/mISDN/tei.c
+++ b/drivers/isdn/mISDN/tei.c
@@ -404,10 +404,7 @@  dl_unit_data(struct manager *mgr, struct sk_buff *skb)
 static unsigned int
-	u16 x;
-	get_random_bytes(&x, sizeof(x));
-	return x;
+	return get_random_u32() & 0xffff;
 static struct layer2 *