diff mbox series

[net] s390/qeth: support net namespaces for L3 devices

Message ID 20200327110042.50797-1-jwi@linux.ibm.com
State Accepted
Delegated to: David Miller
Headers show
Series [net] s390/qeth: support net namespaces for L3 devices | expand

Commit Message

Julian Wiedmann March 27, 2020, 11 a.m. UTC
Enable the L3 driver's IPv4 address notifier to watch for events on qeth
devices that have been moved into a net namespace. We need to program
those IPs into the HW just as usual, otherwise inbound traffic won't
flow.

Fixes: 6133fb1aa137 ("[NETNS]: Disable inetaddr notifiers in namespaces other than initial.")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
---
 drivers/s390/net/qeth_l3_main.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

David Miller March 27, 2020, 10:39 p.m. UTC | #1
From: Julian Wiedmann <jwi@linux.ibm.com>
Date: Fri, 27 Mar 2020 12:00:42 +0100

> Enable the L3 driver's IPv4 address notifier to watch for events on qeth
> devices that have been moved into a net namespace. We need to program
> those IPs into the HW just as usual, otherwise inbound traffic won't
> flow.
> 
> Fixes: 6133fb1aa137 ("[NETNS]: Disable inetaddr notifiers in namespaces other than initial.")
> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>

This looks more like a feature, openning the L3 driver into multiple
namespaces, rather than a critical fix.
Julian Wiedmann March 28, 2020, 10:34 a.m. UTC | #2
On 27.03.20 23:39, David Miller wrote:
> From: Julian Wiedmann <jwi@linux.ibm.com>
> Date: Fri, 27 Mar 2020 12:00:42 +0100
> 
>> Enable the L3 driver's IPv4 address notifier to watch for events on qeth
>> devices that have been moved into a net namespace. We need to program
>> those IPs into the HW just as usual, otherwise inbound traffic won't
>> flow.
>>
>> Fixes: 6133fb1aa137 ("[NETNS]: Disable inetaddr notifiers in namespaces other than initial.")
>> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
> 
> This looks more like a feature, openning the L3 driver into multiple
> namespaces, rather than a critical fix.
> 

Definitely not 'critical', agreed. It's rather silly though that things
currently work just fine for IPv6, but not for IPv4.

Mind queueing this up for net-next then instead? Thanks.
David Miller March 30, 2020, 5:02 a.m. UTC | #3
From: Julian Wiedmann <jwi@linux.ibm.com>
Date: Fri, 27 Mar 2020 12:00:42 +0100

> Enable the L3 driver's IPv4 address notifier to watch for events on qeth
> devices that have been moved into a net namespace. We need to program
> those IPs into the HW just as usual, otherwise inbound traffic won't
> flow.
> 
> Fixes: 6133fb1aa137 ("[NETNS]: Disable inetaddr notifiers in namespaces other than initial.")
> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>

Applied to net-next.
diff mbox series

Patch

diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
index 82f800d1d7b3..46c212118022 100644
--- a/drivers/s390/net/qeth_l3_main.c
+++ b/drivers/s390/net/qeth_l3_main.c
@@ -2204,9 +2204,6 @@  static int qeth_l3_ip_event(struct notifier_block *this,
 	struct qeth_ipaddr addr;
 	struct qeth_card *card;
 
-	if (dev_net(dev) != &init_net)
-		return NOTIFY_DONE;
-
 	card = qeth_l3_get_card_from_dev(dev);
 	if (!card)
 		return NOTIFY_DONE;