diff mbox series

[v2,net-next] net: dsa: sja1105: Avoid error message for unknown PHY mode on disabled ports

Message ID 20200319201210.22824-1-olteanv@gmail.com
State Accepted
Delegated to: David Miller
Headers show
Series [v2,net-next] net: dsa: sja1105: Avoid error message for unknown PHY mode on disabled ports | expand

Commit Message

Vladimir Oltean March 19, 2020, 8:12 p.m. UTC 
From: Vladimir Oltean <vladimir.oltean@nxp.com>

When sja1105_init_mii_settings iterates over the port list, it prints
this message for disabled ports, because they don't have a valid
phy-mode:

[    4.778702] sja1105 spi2.0: Unsupported PHY mode unknown!

Suggested-by: Andrew Lunn <andrew@lunn.ch>
Suggested-by: Vivien Didelot <vivien.didelot@gmail.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/dsa/sja1105/sja1105_main.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Florian Fainelli March 19, 2020, 8:16 p.m. UTC | #1 
On 3/19/20 1:12 PM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> When sja1105_init_mii_settings iterates over the port list, it prints
> this message for disabled ports, because they don't have a valid
> phy-mode:
> 
> [    4.778702] sja1105 spi2.0: Unsupported PHY mode unknown!
> 
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Suggested-by: Vivien Didelot <vivien.didelot@gmail.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Vivien Didelot March 19, 2020, 9:08 p.m. UTC | #2 
On Thu, 19 Mar 2020 22:12:10 +0200, Vladimir Oltean <olteanv@gmail.com> wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> When sja1105_init_mii_settings iterates over the port list, it prints
> this message for disabled ports, because they don't have a valid
> phy-mode:
> 
> [    4.778702] sja1105 spi2.0: Unsupported PHY mode unknown!
> 
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Suggested-by: Vivien Didelot <vivien.didelot@gmail.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
David Miller March 20, 2020, 4:38 a.m. UTC | #3 
From: Vladimir Oltean <olteanv@gmail.com>
Date: Thu, 19 Mar 2020 22:12:10 +0200

> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> When sja1105_init_mii_settings iterates over the port list, it prints
> this message for disabled ports, because they don't have a valid
> phy-mode:
> 
> [    4.778702] sja1105 spi2.0: Unsupported PHY mode unknown!
> 
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Suggested-by: Vivien Didelot <vivien.didelot@gmail.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
index d8123288c572..edf57ea07083 100644
--- a/drivers/net/dsa/sja1105/sja1105_main.c
+++ b/drivers/net/dsa/sja1105/sja1105_main.c
@@ -162,6 +162,9 @@  static int sja1105_init_mii_settings(struct sja1105_private *priv,
 	mii = table->entries;
 
 	for (i = 0; i < SJA1105_NUM_PORTS; i++) {
+		if (dsa_is_unused_port(priv->ds, i))
+			continue;
+
 		switch (ports[i].phy_mode) {
 		case PHY_INTERFACE_MODE_MII:
 			mii->xmii_mode[i] = XMII_MODE_MII;