| Message ID | 20200316021428.48919-4-snelson@pensando.io |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | ionic bits and bytes | expand |
On Sun, Mar 15, 2020 at 07:14:26PM -0700, Shannon Nelson wrote: > Remove the adminq's napi struct when tearing down > the adminq. > > Signed-off-by: Shannon Nelson <snelson@pensando.io> > --- > drivers/net/ethernet/pensando/ionic/ionic_lif.c | 1 + > 1 file changed, 1 insertion(+) > It looks like a fix to me, and I would expect Fixes line here. Thanks
On 3/15/20 11:52 PM, Leon Romanovsky wrote: > On Sun, Mar 15, 2020 at 07:14:26PM -0700, Shannon Nelson wrote: >> Remove the adminq's napi struct when tearing down >> the adminq. >> >> Signed-off-by: Shannon Nelson <snelson@pensando.io> >> --- >> drivers/net/ethernet/pensando/ionic/ionic_lif.c | 1 + >> 1 file changed, 1 insertion(+) >> > It looks like a fix to me, and I would expect Fixes line here. I suppose they all could include Fixes tags, so I'll re-tag them and add a description line to the last one. Perhaps all but the first could be promoted to net but they're not serious issues so I wasn't going to worry about that. Thanks, sln
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c index 19fd7cc36f28..12e3823b0bc1 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c @@ -2070,6 +2070,7 @@ static void ionic_lif_deinit(struct ionic_lif *lif) ionic_lif_rss_deinit(lif); napi_disable(&lif->adminqcq->napi); + netif_napi_del(&lif->adminqcq->napi); ionic_lif_qcq_deinit(lif, lif->notifyqcq); ionic_lif_qcq_deinit(lif, lif->adminqcq);
Remove the adminq's napi struct when tearing down the adminq. Signed-off-by: Shannon Nelson <snelson@pensando.io> --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 1 + 1 file changed, 1 insertion(+)