| Message ID | 20200313121126.7825-1-elder@linaro.org |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | soc: qcom: ipa: build IPA when COMPILE_TEST is enabled | expand |
From: Alex Elder <elder@linaro.org> Date: Fri, 13 Mar 2020 07:11:26 -0500 > Make CONFIG_QCOM_IPA optionally dependent on CONFIG_COMPILE_TEST. > > Suggested-by: Jakub Kicinski <kuba@kernel.org> > Signed-off-by: Alex Elder <elder@linaro.org> > --- > > David, this implements a suggestion made by Jakub Kicinski. I tested > it with GCC 9.2.1 for x86 and found no errors or warnings in the IPA > code. It is the last IPA change I plan to make for v5.7. > > Once reviewed and found acceptable, it should go through net-next. When I try to use this I end up with the following Kconfig warnings: WARNING: unmet direct dependencies detected for QCOM_SCM Depends on [n]: ARM || ARM64 Selected by [m]: - QCOM_MDT_LOADER [=m] So this needs more work.
On 3/13/20 1:25 PM, David Miller wrote: > From: Alex Elder <elder@linaro.org> > Date: Fri, 13 Mar 2020 07:11:26 -0500 > >> Make CONFIG_QCOM_IPA optionally dependent on CONFIG_COMPILE_TEST. >> >> Suggested-by: Jakub Kicinski <kuba@kernel.org> >> Signed-off-by: Alex Elder <elder@linaro.org> >> --- >> >> David, this implements a suggestion made by Jakub Kicinski. I tested >> it with GCC 9.2.1 for x86 and found no errors or warnings in the IPA >> code. It is the last IPA change I plan to make for v5.7. >> >> Once reviewed and found acceptable, it should go through net-next. > > When I try to use this I end up with the following Kconfig warnings: I'm very sorry about that. I'll look it over again and fix it. I got another report today from LKFT saying that there's a different problem when ARM64 is built 64KB pages. I'll address both of them in an update. -Alex > WARNING: unmet direct dependencies detected for QCOM_SCM > Depends on [n]: ARM || ARM64 > Selected by [m]: > - QCOM_MDT_LOADER [=m] > > So this needs more work. >
diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig index b8cb7cadbf75..bcab7e52d4e6 100644 --- a/drivers/net/ipa/Kconfig +++ b/drivers/net/ipa/Kconfig @@ -1,6 +1,6 @@ config QCOM_IPA tristate "Qualcomm IPA support" - depends on ARCH_QCOM && 64BIT && NET + depends on (ARCH_QCOM || COMPILE_TEST) && 64BIT && NET select QCOM_QMI_HELPERS select QCOM_MDT_LOADER default QCOM_Q6V5_COMMON
Make CONFIG_QCOM_IPA optionally dependent on CONFIG_COMPILE_TEST. Suggested-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Alex Elder <elder@linaro.org> --- David, this implements a suggestion made by Jakub Kicinski. I tested it with GCC 9.2.1 for x86 and found no errors or warnings in the IPA code. It is the last IPA change I plan to make for v5.7. Once reviewed and found acceptable, it should go through net-next. Thanks. -Alex drivers/net/ipa/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)