Message ID | 20200223231711.157699-13-jbi.octave@gmail.com |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | None | expand |
From: Jules Irenge <jbi.octave@gmail.com> Date: Sun, 23 Feb 2020 23:16:53 +0000 > Sparse reports a warning at nr_neigh_start() > warning: context imbalance in nr_neigh_start() - wrong count at exit > The root cause is the missing annotation at nr_neigh_start() > Add the missing __acquires(&nr_neigh_list_lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Applied.
diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c index 637a743c060d..33e7b91fc805 100644 --- a/net/netrom/nr_route.c +++ b/net/netrom/nr_route.c @@ -895,6 +895,7 @@ const struct seq_operations nr_node_seqops = { }; static void *nr_neigh_start(struct seq_file *seq, loff_t *pos) + __acquires(&nr_neigh_list_lock) { spin_lock_bh(&nr_neigh_list_lock); return seq_hlist_start_head(&nr_neigh_list, *pos);
Sparse reports a warning at nr_neigh_start() warning: context imbalance in nr_neigh_start() - wrong count at exit The root cause is the missing annotation at nr_neigh_start() Add the missing __acquires(&nr_neigh_list_lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- net/netrom/nr_route.c | 1 + 1 file changed, 1 insertion(+)