diff mbox series

[net-next,02/16] net/dummy: Ditch driver and module versions

Message ID 20200220145855.255704-3-leon@kernel.org
State Changes Requested
Delegated to: David Miller
Headers show
Series Clean driver, module and FW versions | expand

Commit Message

Leon Romanovsky Feb. 20, 2020, 2:58 p.m. UTC 
From: Leon Romanovsky <leonro@mellanox.com>

Delete constant driver and module versions in favor standard
global version which is unique to whole kernel.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
 drivers/net/dummy.c | 3 ---
 1 file changed, 3 deletions(-)

--
2.24.1

Comments

Sergei Shtylyov Feb. 21, 2020, 9:11 a.m. UTC | #1 
Hello!

On 20.02.2020 17:58, Leon Romanovsky wrote:

> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Delete constant driver and module versions in favor standard
                                                      ^ of?

> global version which is unique to whole kernel.
> 
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
[...]

MBR, Sergei
Leon Romanovsky Feb. 22, 2020, 7:28 a.m. UTC | #2 
On Fri, Feb 21, 2020 at 12:11:19PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 20.02.2020 17:58, Leon Romanovsky wrote:
>
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > Delete constant driver and module versions in favor standard
>                                                      ^ of?

Thanks, I'll fix.

>
> > global version which is unique to whole kernel.
> >
> > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> [...]
>
> MBR, Sergei
diff mbox series

Patch

diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c
index 3031a5fc5427..bab3a9bb5e6f 100644
--- a/drivers/net/dummy.c
+++ b/drivers/net/dummy.c
@@ -42,7 +42,6 @@ 
 #include <linux/u64_stats_sync.h>

 #define DRV_NAME	"dummy"
-#define DRV_VERSION	"1.0"

 static int numdummies = 1;

@@ -104,7 +103,6 @@  static void dummy_get_drvinfo(struct net_device *dev,
 			      struct ethtool_drvinfo *info)
 {
 	strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
-	strlcpy(info->version, DRV_VERSION, sizeof(info->version));
 }

 static const struct ethtool_ops dummy_ethtool_ops = {
@@ -212,4 +210,3 @@  module_init(dummy_init_module);
 module_exit(dummy_cleanup_module);
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_RTNL_LINK(DRV_NAME);
-MODULE_VERSION(DRV_VERSION);