diff mbox series

[v2,net-next] sfc: remove unused variable 'efx_default_channel_type'

Message ID 20200219013458.47620-1-yuehaibing@huawei.com
State Accepted
Delegated to: David Miller
Headers show
Series [v2,net-next] sfc: remove unused variable 'efx_default_channel_type' | expand

Commit Message

Yue Haibing Feb. 19, 2020, 1:34 a.m. UTC
drivers/net/ethernet/sfc/efx.c:116:38: warning:
 efx_default_channel_type defined but not used [-Wunused-const-variable=]

commit 83975485077d ("sfc: move channel alloc/removal code")
left behind this, remove it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 83975485077d ("sfc: move channel alloc/removal code")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: Add Fixes tag
---
 drivers/net/ethernet/sfc/efx.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Martin Habets Feb. 19, 2020, 12:35 p.m. UTC | #1
On 19/02/2020 01:34, YueHaibing wrote:
> drivers/net/ethernet/sfc/efx.c:116:38: warning:
>  efx_default_channel_type defined but not used [-Wunused-const-variable=]
> 
> commit 83975485077d ("sfc: move channel alloc/removal code")
> left behind this, remove it.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 83975485077d ("sfc: move channel alloc/removal code")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Martin Habets <mhabets@solarflare.com>

> ---
> v2: Add Fixes tag
> ---
>  drivers/net/ethernet/sfc/efx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
> index 4481f21..256807c 100644
> --- a/drivers/net/ethernet/sfc/efx.c
> +++ b/drivers/net/ethernet/sfc/efx.c
> @@ -113,7 +113,6 @@ MODULE_PARM_DESC(debug, "Bitmapped debugging message enable value");
>   *
>   *************************************************************************/
>  
> -static const struct efx_channel_type efx_default_channel_type;
>  static void efx_remove_port(struct efx_nic *efx);
>  static int efx_xdp_setup_prog(struct efx_nic *efx, struct bpf_prog *prog);
>  static int efx_xdp(struct net_device *dev, struct netdev_bpf *xdp);
>
David Miller Feb. 20, 2020, 12:26 a.m. UTC | #2
From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 19 Feb 2020 09:34:58 +0800

> drivers/net/ethernet/sfc/efx.c:116:38: warning:
>  efx_default_channel_type defined but not used [-Wunused-const-variable=]
> 
> commit 83975485077d ("sfc: move channel alloc/removal code")
> left behind this, remove it.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 83975485077d ("sfc: move channel alloc/removal code")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: Add Fixes tag

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 4481f21..256807c 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -113,7 +113,6 @@  MODULE_PARM_DESC(debug, "Bitmapped debugging message enable value");
  *
  *************************************************************************/
 
-static const struct efx_channel_type efx_default_channel_type;
 static void efx_remove_port(struct efx_nic *efx);
 static int efx_xdp_setup_prog(struct efx_nic *efx, struct bpf_prog *prog);
 static int efx_xdp(struct net_device *dev, struct netdev_bpf *xdp);