Message ID | 20200209171431.19907-1-ymdatta.work@gmail.com |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
Series | [v2] staging: qlge: remove spaces at the start of a line | expand |
On Sun, Feb 09, 2020 at 10:44:30PM +0530, Mohana Datta Yelugoti wrote: > This patch fixes "WARNING: please, no spaces at the start of a > line" by checkpatch.pl by replacing spaces with the tab. > > Signed-off-by: Mohana Datta Yelugoti <ymdatta.work@gmail.com> > --- > drivers/staging/qlge/qlge_main.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) What changed from v1? Always put that below the --- line as documented. Please try again with a v3. thanks, greg k-h
On Sun, 2020-02-09 at 22:44 +0530, Mohana Datta Yelugoti wrote: > This patch fixes "WARNING: please, no spaces at the start of a > line" by checkpatch.pl by replacing spaces with the tab. > Signed-off-by: Mohana Datta Yelugoti <ymdatta.work@gmail.com> > --- Hello Mohana. What changed in the v2? When you send a new revision of a patch, it's good form to describe the differences between the patches below the --- line So here you should write something like V2: Improved patch description Also, the form of the code could be rewritten using // comments while aligning all the options, even those commented out currently with /* ... */ Something like: drivers/staging/qlge/qlge_main.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index ef8037..f25cd2 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -52,16 +52,22 @@ MODULE_LICENSE("GPL"); MODULE_VERSION(DRV_VERSION); static const u32 default_msg = - NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK | -/* NETIF_MSG_TIMER | */ - NETIF_MSG_IFDOWN | - NETIF_MSG_IFUP | - NETIF_MSG_RX_ERR | - NETIF_MSG_TX_ERR | -/* NETIF_MSG_TX_QUEUED | */ -/* NETIF_MSG_INTR | NETIF_MSG_TX_DONE | NETIF_MSG_RX_STATUS | */ -/* NETIF_MSG_PKTDATA | */ - NETIF_MSG_HW | NETIF_MSG_WOL | 0; + NETIF_MSG_DRV | + NETIF_MSG_PROBE | + NETIF_MSG_LINK | +// NETIF_MSG_TIMER | + NETIF_MSG_IFDOWN | + NETIF_MSG_IFUP | + NETIF_MSG_RX_ERR | + NETIF_MSG_TX_ERR | +// NETIF_MSG_TX_QUEUED | +// NETIF_MSG_INTR | +// NETIF_MSG_TX_DONE | +// NETIF_MSG_RX_STATUS | +// NETIF_MSG_PKTDATA | + NETIF_MSG_HW | + NETIF_MSG_WOL | + 0; static int debug = -1; /* defaults above */ module_param(debug, int, 0664); > drivers/staging/qlge/qlge_main.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > index ef8037d0b52e..86b9b7314a40 100644 > --- a/drivers/staging/qlge/qlge_main.c > +++ b/drivers/staging/qlge/qlge_main.c > @@ -52,16 +52,16 @@ MODULE_LICENSE("GPL"); > MODULE_VERSION(DRV_VERSION); > > static const u32 default_msg = > - NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK | > + NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK | > /* NETIF_MSG_TIMER | */ > - NETIF_MSG_IFDOWN | > - NETIF_MSG_IFUP | > - NETIF_MSG_RX_ERR | > - NETIF_MSG_TX_ERR | > + NETIF_MSG_IFDOWN | > + NETIF_MSG_IFUP | > + NETIF_MSG_RX_ERR | > + NETIF_MSG_TX_ERR | > /* NETIF_MSG_TX_QUEUED | */ > /* NETIF_MSG_INTR | NETIF_MSG_TX_DONE | NETIF_MSG_RX_STATUS | */ > /* NETIF_MSG_PKTDATA | */ > - NETIF_MSG_HW | NETIF_MSG_WOL | 0; > + NETIF_MSG_HW | NETIF_MSG_WOL | 0; > > static int debug = -1; /* defaults above */ > module_param(debug, int, 0664);
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index ef8037d0b52e..86b9b7314a40 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -52,16 +52,16 @@ MODULE_LICENSE("GPL"); MODULE_VERSION(DRV_VERSION); static const u32 default_msg = - NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK | + NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK | /* NETIF_MSG_TIMER | */ - NETIF_MSG_IFDOWN | - NETIF_MSG_IFUP | - NETIF_MSG_RX_ERR | - NETIF_MSG_TX_ERR | + NETIF_MSG_IFDOWN | + NETIF_MSG_IFUP | + NETIF_MSG_RX_ERR | + NETIF_MSG_TX_ERR | /* NETIF_MSG_TX_QUEUED | */ /* NETIF_MSG_INTR | NETIF_MSG_TX_DONE | NETIF_MSG_RX_STATUS | */ /* NETIF_MSG_PKTDATA | */ - NETIF_MSG_HW | NETIF_MSG_WOL | 0; + NETIF_MSG_HW | NETIF_MSG_WOL | 0; static int debug = -1; /* defaults above */ module_param(debug, int, 0664);
This patch fixes "WARNING: please, no spaces at the start of a line" by checkpatch.pl by replacing spaces with the tab. Signed-off-by: Mohana Datta Yelugoti <ymdatta.work@gmail.com> --- drivers/staging/qlge/qlge_main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)