| Message ID | 20200104195131.16577-4-info@metux.net |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [1/8] net: 8021q: remove unneeded MODULE_VERSION() usage | expand |
On Saturday, 4 January 2020 20:51:27 CET Enrico Weigelt, metux IT consult wrote: > Use netdev_info() / netdev_warn() instead of pr_info() / pr_warn() > for more consistent log output. > > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> > --- Patch description has nothing to do with the actual patch. Kind regards, Sven > net/ipv4/tcp_cubic.c | 1 - > net/ipv4/tcp_illinois.c | 1 - > net/ipv4/tcp_nv.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/net/ipv4/tcp_cubic.c b/net/ipv4/tcp_cubic.c > index 1b3d032a4df2..83fda965186d 100644 > --- a/net/ipv4/tcp_cubic.c > +++ b/net/ipv4/tcp_cubic.c > @@ -513,4 +513,3 @@ module_exit(cubictcp_unregister); > MODULE_AUTHOR("Sangtae Ha, Stephen Hemminger"); > MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("CUBIC TCP"); > -MODULE_VERSION("2.3"); > diff --git a/net/ipv4/tcp_illinois.c b/net/ipv4/tcp_illinois.c > index 00e54873213e..8cc9967e82ef 100644 > --- a/net/ipv4/tcp_illinois.c > +++ b/net/ipv4/tcp_illinois.c > @@ -355,4 +355,3 @@ module_exit(tcp_illinois_unregister); > MODULE_AUTHOR("Stephen Hemminger, Shao Liu"); > MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("TCP Illinois"); > -MODULE_VERSION("1.0"); > diff --git a/net/ipv4/tcp_nv.c b/net/ipv4/tcp_nv.c > index 95db7a11ba2a..b3879fb24d33 100644 > --- a/net/ipv4/tcp_nv.c > +++ b/net/ipv4/tcp_nv.c > @@ -499,4 +499,3 @@ module_exit(tcpnv_unregister); > MODULE_AUTHOR("Lawrence Brakmo"); > MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("TCP NV"); > -MODULE_VERSION("1.0"); >
On Sat, Jan 4, 2020 at 4:54 PM Enrico Weigelt, metux IT consult <info@metux.net> wrote: > > Use netdev_info() / netdev_warn() instead of pr_info() / pr_warn() > for more consistent log output. > > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> > --- > net/ipv4/tcp_cubic.c | 1 - > net/ipv4/tcp_illinois.c | 1 - > net/ipv4/tcp_nv.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/net/ipv4/tcp_cubic.c b/net/ipv4/tcp_cubic.c > index 1b3d032a4df2..83fda965186d 100644 > --- a/net/ipv4/tcp_cubic.c > +++ b/net/ipv4/tcp_cubic.c > @@ -513,4 +513,3 @@ module_exit(cubictcp_unregister); > MODULE_AUTHOR("Sangtae Ha, Stephen Hemminger"); > MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("CUBIC TCP"); > -MODULE_VERSION("2.3"); Commit message and code change do not match.
diff --git a/net/ipv4/tcp_cubic.c b/net/ipv4/tcp_cubic.c index 1b3d032a4df2..83fda965186d 100644 --- a/net/ipv4/tcp_cubic.c +++ b/net/ipv4/tcp_cubic.c @@ -513,4 +513,3 @@ module_exit(cubictcp_unregister); MODULE_AUTHOR("Sangtae Ha, Stephen Hemminger"); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("CUBIC TCP"); -MODULE_VERSION("2.3"); diff --git a/net/ipv4/tcp_illinois.c b/net/ipv4/tcp_illinois.c index 00e54873213e..8cc9967e82ef 100644 --- a/net/ipv4/tcp_illinois.c +++ b/net/ipv4/tcp_illinois.c @@ -355,4 +355,3 @@ module_exit(tcp_illinois_unregister); MODULE_AUTHOR("Stephen Hemminger, Shao Liu"); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("TCP Illinois"); -MODULE_VERSION("1.0"); diff --git a/net/ipv4/tcp_nv.c b/net/ipv4/tcp_nv.c index 95db7a11ba2a..b3879fb24d33 100644 --- a/net/ipv4/tcp_nv.c +++ b/net/ipv4/tcp_nv.c @@ -499,4 +499,3 @@ module_exit(tcpnv_unregister); MODULE_AUTHOR("Lawrence Brakmo"); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("TCP NV"); -MODULE_VERSION("1.0");
Use netdev_info() / netdev_warn() instead of pr_info() / pr_warn() for more consistent log output. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> --- net/ipv4/tcp_cubic.c | 1 - net/ipv4/tcp_illinois.c | 1 - net/ipv4/tcp_nv.c | 1 - 3 files changed, 3 deletions(-)