[bpf-next,03/13] bpf: Add enum support to btf_ctx_access()

Message ID	20191214004744.1652395-1-kafai@fb.com
State	Changes Requested
Delegated to:	BPF Maintainers
Headers	show Return-Path: <netdev-owner@vger.kernel.org> Smtp-Origin-Hostprefix: devbig From: Martin KaFai Lau <kafai@fb.com> Smtp-Origin-Hostname: devbig005.ftw2.facebook.com To: <bpf@vger.kernel.org> CC: Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, David Miller <davem@davemloft.net>, <kernel-team@fb.com>, <netdev@vger.kernel.org> Smtp-Origin-Cluster: ftw2c04 Subject: [PATCH bpf-next 03/13] bpf: Add enum support to btf_ctx_access() Date: Fri, 13 Dec 2019 16:47:44 -0800 Message-ID: <20191214004744.1652395-1-kafai@fb.com> In-Reply-To: <20191214004737.1652076-1-kafai@fb.com> References: <20191214004737.1652076-1-kafai@fb.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk
Series	Introduce BPF STRUCT_OPS \| expand [bpf-next,00/13] Introduce BPF STRUCT_OPS [bpf-next,01/13] bpf: Save PTR_TO_BTF_ID register state when spilling to stack [bpf-next,02/13] bpf: Avoid storing modifier to info->btf_id [bpf-next,03/13] bpf: Add enum support to btf_ctx_access() [bpf-next,04/13] bpf: Support bitfield read access in btf_struct_access [bpf-next,05/13] bpf: Introduce BPF_PROG_TYPE_STRUCT_OPS [bpf-next,06/13] bpf: Introduce BPF_MAP_TYPE_STRUCT_OPS [bpf-next,07/13] bpf: tcp: Support tcp_congestion_ops in bpf [bpf-next,08/13] bpf: Add BPF_FUNC_tcp_send_ack helper [bpf-next,09/13] bpf: Add BPF_FUNC_jiffies [bpf-next,10/13] bpf: Synch uapi bpf.h to tools/ [bpf-next,11/13] bpf: libbpf: Add STRUCT_OPS support [bpf-next,12/13] bpf: Add bpf_dctcp example [bpf-next,13/13] bpf: Add bpf_cubic example

Message ID

20191214004744.1652395-1-kafai@fb.com

State

Changes Requested

Delegated to:

BPF Maintainers

Headers

Smtp-Origin-Hostprefix: devbig
From: Martin KaFai Lau <kafai@fb.com>
Smtp-Origin-Hostname: devbig005.ftw2.facebook.com
To: <bpf@vger.kernel.org>
CC: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	David Miller <davem@davemloft.net>, <kernel-team@fb.com>,
	<netdev@vger.kernel.org>
Smtp-Origin-Cluster: ftw2c04
Subject: [PATCH bpf-next 03/13] bpf: Add enum support to btf_ctx_access()
Date: Fri, 13 Dec 2019 16:47:44 -0800
Message-ID: <20191214004744.1652395-1-kafai@fb.com>
In-Reply-To: <20191214004737.1652076-1-kafai@fb.com>
References: <20191214004737.1652076-1-kafai@fb.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: netdev-owner@vger.kernel.org
Precedence: bulk

Series

Introduce BPF STRUCT_OPS | expand

It allows bpf prog (e.g. tracing) to attach to a kernel function that takes enum argument. Signed-off-by: Martin KaFai Lau <kafai@fb.com> --- kernel/bpf/btf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yonghong Song Dec. 16, 2019, 9:36 p.m. UTC | #1

On 12/13/19 4:47 PM, Martin KaFai Lau wrote:
> It allows bpf prog (e.g. tracing) to attach
> to a kernel function that takes enum argument.
> 
> Signed-off-by: Martin KaFai Lau <kafai@fb.com>

Acked-by: Yonghong Song <yhs@fb.com>

diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
index 88359a4bccb0..6e652643849b 100644
--- a/kernel/bpf/btf.c
+++ b/kernel/bpf/btf.c
@@ -3676,7 +3676,7 @@  bool btf_ctx_access(int off, int size, enum bpf_access_type type,
 	/* skip modifiers */
 	while (btf_type_is_modifier(t))
 		t = btf_type_by_id(btf, t->type);
-	if (btf_type_is_int(t))
+	if (btf_type_is_int(t) || btf_type_is_enum(t))
 		/* accessing a scalar */
 		return true;
 	if (!btf_type_is_ptr(t)) {

[bpf-next,03/13] bpf: Add enum support to btf_ctx_access()

Commit Message

Comments

Patch