diff mbox series

[net] net-sysfs: fix netdev_queue_add_kobject() breakage

Message ID 20191121031907.159416-1-edumazet@google.com
State Accepted
Delegated to: David Miller
Headers show
Series [net] net-sysfs: fix netdev_queue_add_kobject() breakage | expand

Commit Message

Eric Dumazet Nov. 21, 2019, 3:19 a.m. UTC 
kobject_put() should only be called in error path.

Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jouni Hogander <jouni.hogander@unikie.com>
---
 net/core/net-sysfs.c | 1 +
 1 file changed, 1 insertion(+)

Comments

David Miller Nov. 21, 2019, 6:16 a.m. UTC | #1 
From: Eric Dumazet <edumazet@google.com>
Date: Wed, 20 Nov 2019 19:19:07 -0800

> kobject_put() should only be called in error path.
> 
> Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Jouni Hogander <jouni.hogander@unikie.com>

Sorry, I should push back harder in the future.

Applied, thanks Eric.
diff mbox series

Patch

diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 4f404bf33e44c977c1a8ba00706817b76215b75c..ae3bcb1540ec57df311dac6847323a23a74ec960 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -1474,6 +1474,7 @@  static int netdev_queue_add_kobject(struct net_device *dev, int index)
 #endif
 
 	kobject_uevent(kobj, KOBJ_ADD);
+	return 0;
 
 err:
 	kobject_put(kobj);