| Message ID | 20191106002923.109344-5-abhishekpandit@chromium.org |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | David Miller |
| Headers | show |
| Series | Bluetooth: hci_bcm: Additional changes for BCM4354 support | expand |
On Tue, Nov 05, 2019 at 04:29:23PM -0800, Abhishek Pandit-Subedi wrote: > Add documentation for pcm-parameters. > > Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> > > --- > > Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > index c749dc297624..ae60277b5569 100644 > --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > @@ -29,6 +29,9 @@ Optional properties: > - "lpo": external low power 32.768 kHz clock > - vbat-supply: phandle to regulator supply for VBAT > - vddio-supply: phandle to regulator supply for VDDIO > + - pcm-parameters: When set, will configure PCM parameters on the device. The > + contents should be a 10-byte array corresponding to the pcm params (see > + btbcm.h for more information). Needs a vendor prefix. > > > Example: > @@ -40,5 +43,6 @@ Example: > bluetooth { > compatible = "brcm,bcm43438-bt"; > max-speed = <921600>; > + pcm-parameters = [1 2 0 1 1 0 0 0 0 0]; > }; > }; > -- > 2.24.0.rc1.363.gb1bccd3e3d-goog >
Hi Abhishek, > Add documentation for pcm-parameters. > > Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> > > --- > > Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > index c749dc297624..ae60277b5569 100644 > --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > @@ -29,6 +29,9 @@ Optional properties: > - "lpo": external low power 32.768 kHz clock > - vbat-supply: phandle to regulator supply for VBAT > - vddio-supply: phandle to regulator supply for VDDIO > + - pcm-parameters: When set, will configure PCM parameters on the device. The > + contents should be a 10-byte array corresponding to the pcm params (see > + btbcm.h for more information). > > > Example: > @@ -40,5 +43,6 @@ Example: > bluetooth { > compatible = "brcm,bcm43438-bt"; > max-speed = <921600>; > + pcm-parameters = [1 2 0 1 1 0 0 0 0 0]; > }; > }; I think about 1-2 years there have been a discussion on how to represent these values in a DT. I prefer we split these into separate values so it becomes usable by other drivers / vendors as well. In addition, maybe we start to focus on the values that differ from the default. Regards Marcel
diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt index c749dc297624..ae60277b5569 100644 --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt @@ -29,6 +29,9 @@ Optional properties: - "lpo": external low power 32.768 kHz clock - vbat-supply: phandle to regulator supply for VBAT - vddio-supply: phandle to regulator supply for VDDIO + - pcm-parameters: When set, will configure PCM parameters on the device. The + contents should be a 10-byte array corresponding to the pcm params (see + btbcm.h for more information). Example: @@ -40,5 +43,6 @@ Example: bluetooth { compatible = "brcm,bcm43438-bt"; max-speed = <921600>; + pcm-parameters = [1 2 0 1 1 0 0 0 0 0]; }; };
Add documentation for pcm-parameters. Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> --- Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 4 ++++ 1 file changed, 4 insertions(+)