Message ID | 20191105211707.10300-4-jakub.kicinski@netronome.com |
---|---|
State | Accepted |
Delegated to: | David Ahern |
Headers | show |
Series | devlink: improve parameter checking, resources and namespaces | expand |
Tue, Nov 05, 2019 at 10:17:07PM CET, jakub.kicinski@netronome.com wrote: >Resource size is a 64 bit attribute at netlink level. >Make the command line argument 64 bit as well. > >Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> This can be: Fixes: 8cd644095842 ("devlink: Add support for devlink resource abstraction") Anyway: Acked-by: Jiri Pirko <jiri@mellanox.com> Thanks! >--- > devlink/devlink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/devlink/devlink.c b/devlink/devlink.c >index e05a2336787a..ea3f992ee0d7 100644 >--- a/devlink/devlink.c >+++ b/devlink/devlink.c >@@ -283,7 +283,7 @@ struct dl_opts { > bool dpipe_counters_enable; > bool eswitch_encap_mode; > const char *resource_path; >- uint32_t resource_size; >+ uint64_t resource_size; > uint32_t resource_id; > bool resource_id_valid; > const char *param_name; >@@ -1348,7 +1348,7 @@ static int dl_argv_parse(struct dl *dl, uint64_t o_required, > } else if (dl_argv_match(dl, "size") && > (o_all & DL_OPT_RESOURCE_SIZE)) { > dl_arg_inc(dl); >- err = dl_argv_uint32_t(dl, &opts->resource_size); >+ err = dl_argv_uint64_t(dl, &opts->resource_size); > if (err) > return err; > o_found |= DL_OPT_RESOURCE_SIZE; >-- >2.23.0 >
diff --git a/devlink/devlink.c b/devlink/devlink.c index e05a2336787a..ea3f992ee0d7 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -283,7 +283,7 @@ struct dl_opts { bool dpipe_counters_enable; bool eswitch_encap_mode; const char *resource_path; - uint32_t resource_size; + uint64_t resource_size; uint32_t resource_id; bool resource_id_valid; const char *param_name; @@ -1348,7 +1348,7 @@ static int dl_argv_parse(struct dl *dl, uint64_t o_required, } else if (dl_argv_match(dl, "size") && (o_all & DL_OPT_RESOURCE_SIZE)) { dl_arg_inc(dl); - err = dl_argv_uint32_t(dl, &opts->resource_size); + err = dl_argv_uint64_t(dl, &opts->resource_size); if (err) return err; o_found |= DL_OPT_RESOURCE_SIZE;
Resource size is a 64 bit attribute at netlink level. Make the command line argument 64 bit as well. Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> --- devlink/devlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)