diff mbox series

[02/33] can: gs_usb: gs_can_open(): prevent memory leak

Message ID	20191105163215.30194-3-mkl@pengutronix.de
State	Accepted
Delegated to:	David Miller
Headers	show Return-Path: <netdev-owner@vger.kernel.org> From: Marc Kleine-Budde <mkl@pengutronix.de> To: netdev@vger.kernel.org Cc: davem@davemloft.net, linux-can@vger.kernel.org, kernel@pengutronix.de, Navid Emamdoost <navid.emamdoost@gmail.com>, linux-stable <stable@vger.kernel.org>, Marc Kleine-Budde <mkl@pengutronix.de> Subject: [PATCH 02/33] can: gs_usb: gs_can_open(): prevent memory leak Date: Tue, 5 Nov 2019 17:31:44 +0100 Message-Id: <20191105163215.30194-3-mkl@pengutronix.de> In-Reply-To: <20191105163215.30194-1-mkl@pengutronix.de> References: <20191105163215.30194-1-mkl@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk
Series	pull-request: can 2019-11-05 \| expand pull-request: can 2019-11-05 [02/33] can: gs_usb: gs_can_open(): prevent memory leak [03/33] can: mcba_usb: fix use-after-free on disconnect [04/33] can: usb_8dev: fix use-after-free on disconnect [05/33] can: flexcan: disable completely the ECC mechanism [06/33] can: peak_usb: fix a potential out-of-sync while decoding packets [07/33] can: peak_usb: fix slab info leak [08/33] can: peak_usb: report bus recovery as well [09/33] can: c_can: c_can_poll(): only read status register after status IRQ [10/33] can: c_can: D_CAN: c_can_chip_config(): perform a sofware reset on open [11/33] can: c_can: C_CAN: add bus recovery events [12/33] can: xilinx_can: Fix flags field initialization for axi can [13/33] can: rx-offload: can_rx_offload_queue_sorted(): fix error handling, avoid skb mem leak [14/33] can: rx-offload: can_rx_offload_queue_tail(): fix error handling, avoid skb mem leak [15/33] can: rx-offload: can_rx_offload_offload_one(): do not increase the skb_queue beyond skb_que… [16/33] can: rx-offload: can_rx_offload_offload_one(): increment rx_fifo_errors on queue overflow o… [17/33] can: rx-offload: can_rx_offload_offload_one(): use ERR_PTR() to propagate error value in ca… [18/33] can: rx-offload: can_rx_offload_irq_offload_timestamp(): continue on error [19/33] can: rx-offload: can_rx_offload_irq_offload_fifo(): continue on error [20/33] can: flexcan: increase error counters if skb enqueueing via can_rx_offload_queue_sorted() f… [21/33] can: ti_hecc: ti_hecc_error(): increase error counters if skb enqueueing via can_rx_offload… [22/33] can: ti_hecc: ti_hecc_stop(): stop the CPK on down [23/33] can: ti_hecc: keep MIM and MD set [24/33] can: ti_hecc: release the mailbox a bit earlier [25/33] can: ti_hecc: add fifo overflow error reporting [26/33] can: ti_hecc: properly report state changes [27/33] can: ti_hecc: add missing state changes [28/33] can: j1939: fix resource leak of skb on error return paths [29/33] can: j1939: fix memory leak if filters was set [30/33] can: j1939: transport: j1939_session_fresh_new(): make sure EOMA is send with the total mes… [31/33] can: j1939: transport: j1939_xtp_rx_eoma_one(): Add sanity check for correct total message … [32/33] can: mcp251x: mcp251x_restart_work_handler(): Fix potential force_quit race condition [33/33] can: don't use deprecated license identifiers

Commit Message

Marc Kleine-Budde Nov. 5, 2019, 4:31 p.m. UTC

From: Navid Emamdoost <navid.emamdoost@gmail.com>

In gs_can_open() if usb_submit_urb() fails the allocated urb should be
released.

Fixes: d08e973a77d1 ("can: gs_usb: Added support for the GS_USB CAN devices")
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/net/can/usb/gs_usb.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

Patch

diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
index bd6eb9967630..2f74f6704c12 100644
--- a/drivers/net/can/usb/gs_usb.c
+++ b/drivers/net/can/usb/gs_usb.c
@@ -623,6 +623,7 @@  static int gs_can_open(struct net_device *netdev)
 					   rc);
 
 				usb_unanchor_urb(urb);
+				usb_free_urb(urb);
 				break;
 			}