| Message ID | 20190921055926.GA18726@mwanda |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] ionic: Fix an error code in ionic_lif_alloc() | expand |
On 9/20/19 10:59 PM, Dan Carpenter wrote: > We need to set the error code on this path. Otherwise it probably > results in a NULL dereference down the line. > > Fixes: aa3198819bea ("ionic: Add RSS support") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/net/ethernet/pensando/ionic/ionic_lif.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c > index db7c82742828..72107a0627a9 100644 > --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c > +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c > @@ -1704,6 +1704,7 @@ static struct ionic_lif *ionic_lif_alloc(struct ionic *ionic, unsigned int index > GFP_KERNEL); > > if (!lif->rss_ind_tbl) { > + err = -ENOMEM; > dev_err(dev, "Failed to allocate rss indirection table, aborting\n"); > goto err_out_free_qcqs; > } Thanks, Dan. Acked-by: Shannon Nelson <snelson@pensando.io>
On Sat, 21 Sep 2019 08:59:26 +0300, Dan Carpenter wrote: > We need to set the error code on this path. Otherwise it probably > results in a NULL dereference down the line. > > Fixes: aa3198819bea ("ionic: Add RSS support") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied, thank you!
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c index db7c82742828..72107a0627a9 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c @@ -1704,6 +1704,7 @@ static struct ionic_lif *ionic_lif_alloc(struct ionic *ionic, unsigned int index GFP_KERNEL); if (!lif->rss_ind_tbl) { + err = -ENOMEM; dev_err(dev, "Failed to allocate rss indirection table, aborting\n"); goto err_out_free_qcqs; }
We need to set the error code on this path. Otherwise it probably results in a NULL dereference down the line. Fixes: aa3198819bea ("ionic: Add RSS support") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 1 + 1 file changed, 1 insertion(+)