| Message ID | 20190807001923.19483-3-jakub.kicinski@netronome.com |
|---|---|
| State | Accepted |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | tools: bpftool: fix pinning error messages | expand |
On Tue, Aug 6, 2019 at 5:21 PM Jakub Kicinski <jakub.kicinski@netronome.com> wrote: > > No error message is currently printed if the pin syscall > itself fails. It got lost in the loadall refactoring. > > Fixes: 77380998d91d ("bpftool: add loadall command") > Reported-by: Andy Lutomirski <luto@kernel.org> > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> > Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com> > --- Acked-by: Andrii Nakryiko <andriin@fb.com> > CC: luto@kernel.org, sdf@google.com > > tools/bpf/bpftool/common.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c > index c52a6ffb8949..6a71324be628 100644 > --- a/tools/bpf/bpftool/common.c > +++ b/tools/bpf/bpftool/common.c > @@ -204,7 +204,11 @@ int do_pin_fd(int fd, const char *name) > if (err) > return err; > > - return bpf_obj_pin(fd, name); > + err = bpf_obj_pin(fd, name); > + if (err) > + p_err("can't pin the object (%s): %s", name, strerror(errno)); > + > + return err; > } > > int do_pin_any(int argc, char **argv, int (*get_fd_by_id)(__u32)) > -- > 2.21.0 >
diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c index c52a6ffb8949..6a71324be628 100644 --- a/tools/bpf/bpftool/common.c +++ b/tools/bpf/bpftool/common.c @@ -204,7 +204,11 @@ int do_pin_fd(int fd, const char *name) if (err) return err; - return bpf_obj_pin(fd, name); + err = bpf_obj_pin(fd, name); + if (err) + p_err("can't pin the object (%s): %s", name, strerror(errno)); + + return err; } int do_pin_any(int argc, char **argv, int (*get_fd_by_id)(__u32))
No error message is currently printed if the pin syscall itself fails. It got lost in the loadall refactoring. Fixes: 77380998d91d ("bpftool: add loadall command") Reported-by: Andy Lutomirski <luto@kernel.org> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com> --- CC: luto@kernel.org, sdf@google.com tools/bpf/bpftool/common.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)