| Message ID | 20190802195602.28414-1-joseespiriki@gmail.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | isdn: hysdn: Fix error spaces around '*' | expand |
On Fri, 2 Aug 2019 19:56:02 +0000 Jose Carlos Cazarin Filho <joseespiriki@gmail.com> wrote: > Fix checkpath error: > CHECK: spaces preferred around that '*' (ctx:WxV) > +extern hysdn_card *card_root; /* pointer to first card */ > > Signed-off-by: Jose Carlos Cazarin Filho <joseespiriki@gmail.com> Read the TODO, these drivers are scheduled for removal, so changes are not helpful at this time.
On Fri, 2019-08-02 at 14:55 -0700, Stephen Hemminger wrote: > On Fri, 2 Aug 2019 19:56:02 +0000 > Jose Carlos Cazarin Filho <joseespiriki@gmail.com> wrote: > > > Fix checkpath error: > > CHECK: spaces preferred around that '*' (ctx:WxV) > > +extern hysdn_card *card_root; /* pointer to first card */ > > > > Signed-off-by: Jose Carlos Cazarin Filho <joseespiriki@gmail.com> > > Read the TODO, these drivers are scheduled for removal, so changes > are not helpful at this time. Maybe better to mark the MAINTAINERS entry obsolete so checkpatch bleats a message about unnecessary changes. --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 30bf852e6d6b..b5df91032574 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8628,7 +8628,7 @@ M: Karsten Keil <isdn@linux-pingi.de> L: isdn4linux@listserv.isdn4linux.de (subscribers-only) L: netdev@vger.kernel.org W: http://www.isdn4linux.de -S: Odd Fixes +S: Obsolete F: Documentation/isdn/ F: drivers/isdn/capi/ F: drivers/staging/isdn/
On Fri, Aug 02, 2019 at 07:56:02PM +0000, Jose Carlos Cazarin Filho wrote: > Fix checkpath error: > CHECK: spaces preferred around that '*' (ctx:WxV) > +extern hysdn_card *card_root; /* pointer to first card */ > > Signed-off-by: Jose Carlos Cazarin Filho <joseespiriki@gmail.com> > --- > Hello all! > This is my first commit to the Linux Kernel, I'm doing this to learn and be able > to contribute more in the future > Peace all! > > drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h > index cdac46a21..f20150d62 100644 > --- a/drivers/staging/isdn/hysdn/hysdn_defs.h > +++ b/drivers/staging/isdn/hysdn/hysdn_defs.h > @@ -220,7 +220,7 @@ typedef struct hycapictrl_info hycapictrl_info; > /*****************/ > /* exported vars */ > /*****************/ > -extern hysdn_card *card_root; /* pointer to first card */ > +extern hysdn_card * card_root; /* pointer to first card */ The original code here is correct, checkpatch must be reporting this incorrectly. thanks, greg k-h
On Sat, 2019-08-03 at 08:32 +0200, Greg KH wrote: > On Fri, Aug 02, 2019 at 07:56:02PM +0000, Jose Carlos Cazarin Filho wrote: > > Fix checkpath error: > > CHECK: spaces preferred around that '*' (ctx:WxV) > > +extern hysdn_card *card_root; /* pointer to first card */ [] > > diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h [] > > @@ -220,7 +220,7 @@ typedef struct hycapictrl_info hycapictrl_info; > > /*****************/ > > /* exported vars */ > > /*****************/ > > -extern hysdn_card *card_root; /* pointer to first card */ > > +extern hysdn_card * card_root; /* pointer to first card */ > > The original code here is correct, checkpatch must be reporting this > incorrectly. Here checkpatch thinks that hydsn_card is an identifier rather than a typedef. It's defined as: typedef struct HYSDN_CARD { ... } hysdn_card; And that confuses checkpatch. kernel source code style would not use a typedef for a struct. A change would be to remove the typedef and declare this as: struct hysdn_card { ... }; And then do a global: sed 's/\bhysdn_card\b/struct hysdn_card/g' But that's not necessary as the driver is likely to be removed.
On Sat, Aug 03, 2019 at 04:15:05AM -0700, Joe Perches wrote: > On Sat, 2019-08-03 at 08:32 +0200, Greg KH wrote: > > On Fri, Aug 02, 2019 at 07:56:02PM +0000, Jose Carlos Cazarin Filho wrote: > > > Fix checkpath error: > > > CHECK: spaces preferred around that '*' (ctx:WxV) > > > +extern hysdn_card *card_root; /* pointer to first card */ > [] > > > diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h > [] > > > @@ -220,7 +220,7 @@ typedef struct hycapictrl_info hycapictrl_info; > > > /*****************/ > > > /* exported vars */ > > > /*****************/ > > > -extern hysdn_card *card_root; /* pointer to first card */ > > > +extern hysdn_card * card_root; /* pointer to first card */ > > > > The original code here is correct, checkpatch must be reporting this > > incorrectly. > > Here checkpatch thinks that hydsn_card is an identifier rather > than a typedef. > > It's defined as: > typedef struct HYSDN_CARD { > ... > } hysdn_card; > > And that confuses checkpatch. > > kernel source code style would not use a typedef for a struct. > > A change would be to remove the typedef and declare this as: > struct hysdn_card { > ... > }; > > And then do a global: > sed 's/\bhysdn_card\b/struct hysdn_card/g' > > But that's not necessary as the driver is likely to be removed. Ah, that makes sense why checkpatch did this, thanks for the information. And yes, it's not worth being changed, as this is going to be deleted. But, I bet we get this sent a lot until it is as it's "easy pickings" :) thanks, greg k-h
On Fri, Aug 02, 2019 at 03:05:05PM -0700, Joe Perches wrote: > On Fri, 2019-08-02 at 14:55 -0700, Stephen Hemminger wrote: > > On Fri, 2 Aug 2019 19:56:02 +0000 > > Jose Carlos Cazarin Filho <joseespiriki@gmail.com> wrote: > > > > > Fix checkpath error: > > > CHECK: spaces preferred around that '*' (ctx:WxV) > > > +extern hysdn_card *card_root; /* pointer to first card */ > > > > > > Signed-off-by: Jose Carlos Cazarin Filho <joseespiriki@gmail.com> > > > > Read the TODO, these drivers are scheduled for removal, so changes > > are not helpful at this time. > > Maybe better to mark the MAINTAINERS entry obsolete so > checkpatch bleats a message about unnecessary changes. > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 30bf852e6d6b..b5df91032574 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8628,7 +8628,7 @@ M: Karsten Keil <isdn@linux-pingi.de> > L: isdn4linux@listserv.isdn4linux.de (subscribers-only) > L: netdev@vger.kernel.org > W: http://www.isdn4linux.de > -S: Odd Fixes > +S: Obsolete > F: Documentation/isdn/ > F: drivers/isdn/capi/ > F: drivers/staging/isdn/ > Good idea, will take this patch now, thanks. greg k-h
On Thu, Aug 08, 2019 at 06:39:05PM +0200, Greg KH wrote: > On Fri, Aug 02, 2019 at 03:05:05PM -0700, Joe Perches wrote: > > On Fri, 2019-08-02 at 14:55 -0700, Stephen Hemminger wrote: > > > On Fri, 2 Aug 2019 19:56:02 +0000 > > > Jose Carlos Cazarin Filho <joseespiriki@gmail.com> wrote: > > > > > > > Fix checkpath error: > > > > CHECK: spaces preferred around that '*' (ctx:WxV) > > > > +extern hysdn_card *card_root; /* pointer to first card */ > > > > > > > > Signed-off-by: Jose Carlos Cazarin Filho <joseespiriki@gmail.com> > > > > > > Read the TODO, these drivers are scheduled for removal, so changes > > > are not helpful at this time. > > > > Maybe better to mark the MAINTAINERS entry obsolete so > > checkpatch bleats a message about unnecessary changes. > > --- > > MAINTAINERS | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 30bf852e6d6b..b5df91032574 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -8628,7 +8628,7 @@ M: Karsten Keil <isdn@linux-pingi.de> > > L: isdn4linux@listserv.isdn4linux.de (subscribers-only) > > L: netdev@vger.kernel.org > > W: http://www.isdn4linux.de > > -S: Odd Fixes > > +S: Obsolete > > F: Documentation/isdn/ > > F: drivers/isdn/capi/ > > F: drivers/staging/isdn/ > > > > Good idea, will take this patch now, thanks. Can you resend this with a s-o-b so I can apply it? thanks, greg k-h
On Thu, 2019-08-08 at 18:40 +0200, Greg KH wrote: > On Thu, Aug 08, 2019 at 06:39:05PM +0200, Greg KH wrote: > > On Fri, Aug 02, 2019 at 03:05:05PM -0700, Joe Perches wrote: > > > On Fri, 2019-08-02 at 14:55 -0700, Stephen Hemminger wrote: > > > > On Fri, 2 Aug 2019 19:56:02 +0000 > > > > Jose Carlos Cazarin Filho <joseespiriki@gmail.com> wrote: > > > > > > > > > Fix checkpath error: > > > > > CHECK: spaces preferred around that '*' (ctx:WxV) > > > > > +extern hysdn_card *card_root; /* pointer to first card */ > > > > > > > > > > Signed-off-by: Jose Carlos Cazarin Filho <joseespiriki@gmail.com> > > > > > > > > Read the TODO, these drivers are scheduled for removal, so changes > > > > are not helpful at this time. > > > > > > Maybe better to mark the MAINTAINERS entry obsolete so > > > checkpatch bleats a message about unnecessary changes. > > > --- > > > MAINTAINERS | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 30bf852e6d6b..b5df91032574 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -8628,7 +8628,7 @@ M: Karsten Keil <isdn@linux-pingi.de> > > > L: isdn4linux@listserv.isdn4linux.de (subscribers-only) > > > L: netdev@vger.kernel.org > > > W: http://www.isdn4linux.de > > > -S: Odd Fixes > > > +S: Obsolete > > > F: Documentation/isdn/ > > > F: drivers/isdn/capi/ > > > F: drivers/staging/isdn/ > > > > > > > Good idea, will take this patch now, thanks. > > Can you resend this with a s-o-b so I can apply it? > > thanks, Hey Greg. It was just an idea and an example. I'm sure you can figure out if you want it. No need for my SOB really. btw: Karsten hasn't acked a patch or been active in 3+ years. Maybe he should go into CREDITS.
diff --git a/drivers/staging/isdn/hysdn/hysdn_defs.h b/drivers/staging/isdn/hysdn/hysdn_defs.h index cdac46a21..f20150d62 100644 --- a/drivers/staging/isdn/hysdn/hysdn_defs.h +++ b/drivers/staging/isdn/hysdn/hysdn_defs.h @@ -220,7 +220,7 @@ typedef struct hycapictrl_info hycapictrl_info; /*****************/ /* exported vars */ /*****************/ -extern hysdn_card *card_root; /* pointer to first card */ +extern hysdn_card * card_root; /* pointer to first card */
Fix checkpath error: CHECK: spaces preferred around that '*' (ctx:WxV) +extern hysdn_card *card_root; /* pointer to first card */ Signed-off-by: Jose Carlos Cazarin Filho <joseespiriki@gmail.com> --- Hello all! This is my first commit to the Linux Kernel, I'm doing this to learn and be able to contribute more in the future Peace all! drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)