| Message ID | 20190730180541.212452-1-andriin@fb.com |
|---|---|
| State | Accepted |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [v2,bpf-next] selftests/bpf: fix clearing buffered output between tests/subtests | expand |
On Tue, Jul 30, 2019 at 11:17 AM Andrii Nakryiko <andriin@fb.com> wrote: > > Clear buffered output once test or subtests finishes even if test was > successful. Not doing this leads to accumulation of output from previous > tests and on first failed tests lots of irrelevant output will be > dumped, greatly confusing things. > > v1->v2: fix Fixes tag, add more context to patch > > Fixes: 3a516a0a3a7b ("selftests/bpf: add sub-tests support for test_progs") > Signed-off-by: Andrii Nakryiko <andriin@fb.com> Applied. Thanks
diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c index 546d99b3ec34..db00196c8315 100644 --- a/tools/testing/selftests/bpf/test_progs.c +++ b/tools/testing/selftests/bpf/test_progs.c @@ -39,22 +39,22 @@ static bool should_run(struct test_selector *sel, int num, const char *name) } static void dump_test_log(const struct prog_test_def *test, bool failed) { if (env.verbose || test->force_log || failed) { if (env.log_cnt) { fprintf(stdout, "%s", env.log_buf); if (env.log_buf[env.log_cnt - 1] != '\n') fprintf(stdout, "\n"); } - env.log_cnt = 0; } + env.log_cnt = 0; } void test__end_subtest() { struct prog_test_def *test = env.test; int sub_error_cnt = error_cnt - test->old_error_cnt; if (sub_error_cnt) env.fail_cnt++; else
Clear buffered output once test or subtests finishes even if test was successful. Not doing this leads to accumulation of output from previous tests and on first failed tests lots of irrelevant output will be dumped, greatly confusing things. v1->v2: fix Fixes tag, add more context to patch Fixes: 3a516a0a3a7b ("selftests/bpf: add sub-tests support for test_progs") Signed-off-by: Andrii Nakryiko <andriin@fb.com> --- tools/testing/selftests/bpf/test_progs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)