| Message ID | 20190724191218.11757-1-mcroce@redhat.com |
|---|---|
| State | Superseded |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | [iproute2] iplink: document the 'link change' subcommand | expand |
On Wed, 24 Jul 2019 21:12:18 +0200 Matteo Croce <mcroce@redhat.com> wrote: > ip link can set parameters both via the 'set' and 'change' keyword. > In fact, 'change' is an alias for 'set'. > Document this in the help and manpage. > > Fixes: 1d93483985f0 ("iplink: use netlink for link configuration") > Signed-off-by: Matteo Croce <mcroce@redhat.com> Probably just done originally for compatibility in some way with ip route. Not sure if it really needs to be documented.
On July 26, 2019 8:25:14 PM GMT+02:00, Stephen Hemminger <stephen@networkplumber.org> wrote: > On Wed, 24 Jul 2019 21:12:18 +0200 > Matteo Croce <mcroce@redhat.com> wrote: > > > ip link can set parameters both via the 'set' and 'change' keyword. > > In fact, 'change' is an alias for 'set'. > > Document this in the help and manpage. > > > > Fixes: 1d93483985f0 ("iplink: use netlink for link configuration") > > Signed-off-by: Matteo Croce <mcroce@redhat.com> > > Probably just done originally for compatibility in some way with ip > route. > Not sure if it really needs to be documented. Maybe not in the output help, but in the manpage we should state it.
diff --git a/ip/iplink.c b/ip/iplink.c index 212a0885..be237c93 100644 --- a/ip/iplink.c +++ b/ip/iplink.c @@ -64,12 +64,12 @@ void iplink_usage(void) "\n" " ip link delete { DEVICE | dev DEVICE | group DEVGROUP } type TYPE [ ARGS ]\n" "\n" - " ip link set { DEVICE | dev DEVICE | group DEVGROUP }\n" + " ip link { set | change } { DEVICE | dev DEVICE | group DEVGROUP }\n" " [ { up | down } ]\n" " [ type TYPE ARGS ]\n"); } else fprintf(stderr, - "Usage: ip link set DEVICE [ { up | down } ]\n"); + "Usage: ip link { set | change } DEVICE [ { up | down } ]\n"); fprintf(stderr, " [ arp { on | off } ]\n" diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index 883d8807..d4be1a0e 100644 --- a/man/man8/ip-link.8.in +++ b/man/man8/ip-link.8.in @@ -1802,7 +1802,8 @@ deleted since it is the default group. .BI type " TYPE " specifies the type of the device. -.SS ip link set - change device attributes +.SS ip link set +.SS ip link change - change device attributes .PP .B Warning: @@ -1815,6 +1816,10 @@ can move the system to an unpredictable state. The solution is to avoid changing several parameters with one .B ip link set call. +.B set +and +.B change +are synonyms and have identical syntax and behavior. .TP .BI dev " DEVICE "
ip link can set parameters both via the 'set' and 'change' keyword. In fact, 'change' is an alias for 'set'. Document this in the help and manpage. Fixes: 1d93483985f0 ("iplink: use netlink for link configuration") Signed-off-by: Matteo Croce <mcroce@redhat.com> --- ip/iplink.c | 4 ++-- man/man8/ip-link.8.in | 7 ++++++- 2 files changed, 8 insertions(+), 3 deletions(-)