| Message ID | 20190706151900.14355-2-josua@solid-run.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | Fix hang of Armada 8040 SoC in orion-mdio | expand |
On Sat, Jul 06, 2019 at 05:18:57PM +0200, josua@solid-run.com wrote: > From: Josua Mayer <josua@solid-run.com> > > Armada 8040 needs four clocks to be enabled for MDIO accesses to work. > Update the binding to allow the extra clock to be specified. > > Cc: stable@vger.kernel.org > Fixes: 6d6a331f44a1 ("dt-bindings: allow up to three clocks for orion-mdio") > Signed-off-by: Josua Mayer <josua@solid-run.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Sat, Jul 6, 2019 at 9:31 AM <josua@solid-run.com> wrote: > > From: Josua Mayer <josua@solid-run.com> > > Armada 8040 needs four clocks to be enabled for MDIO accesses to work. > Update the binding to allow the extra clock to be specified. > > Cc: stable@vger.kernel.org > Fixes: 6d6a331f44a1 ("dt-bindings: allow up to three clocks for orion-mdio") > Signed-off-by: Josua Mayer <josua@solid-run.com> > --- > Documentation/devicetree/bindings/net/marvell-orion-mdio.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt > index 42cd81090a2c..3f3cfc1d8d4d 100644 > --- a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt > +++ b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt > @@ -16,7 +16,7 @@ Required properties: > > Optional properties: > - interrupts: interrupt line number for the SMI error/done interrupt > -- clocks: phandle for up to three required clocks for the MDIO instance > +- clocks: phandle for up to four required clocks for the MDIO instance This needs to enumerate exactly what the clocks are. Shouldn't there be an additional clock-names value too? Rob
> > Optional properties: > > - interrupts: interrupt line number for the SMI error/done interrupt > > -- clocks: phandle for up to three required clocks for the MDIO instance > > +- clocks: phandle for up to four required clocks for the MDIO instance > > This needs to enumerate exactly what the clocks are. Shouldn't there > be an additional clock-names value too? Hi Rob The driver does not care what they are called. It just turns them all on, and turns them off again when removed. Andrew
On Mon, Jul 8, 2019 at 8:41 PM Andrew Lunn <andrew@lunn.ch> wrote: > > > > Optional properties: > > > - interrupts: interrupt line number for the SMI error/done interrupt > > > -- clocks: phandle for up to three required clocks for the MDIO instance > > > +- clocks: phandle for up to four required clocks for the MDIO instance > > > > This needs to enumerate exactly what the clocks are. Shouldn't there > > be an additional clock-names value too? > > Hi Rob > > The driver does not care what they are called. It just turns them all > on, and turns them off again when removed. That's fine for the driver to do, but this is the hardware description. It's not just what they are called, but how many too. Is 1 clock in the DT valid? 0? It would be unusual for a given piece of h/w to function with a variable number of clocks. Rob
On Tue, Jul 09, 2019 at 04:03:28PM -0600, Rob Herring wrote: > On Mon, Jul 8, 2019 at 8:41 PM Andrew Lunn <andrew@lunn.ch> wrote: > > > > > > Optional properties: > > > > - interrupts: interrupt line number for the SMI error/done interrupt > > > > -- clocks: phandle for up to three required clocks for the MDIO instance > > > > +- clocks: phandle for up to four required clocks for the MDIO instance > > > > > > This needs to enumerate exactly what the clocks are. Shouldn't there > > > be an additional clock-names value too? > > > > Hi Rob > > > > The driver does not care what they are called. It just turns them all > > on, and turns them off again when removed. > > That's fine for the driver to do, but this is the hardware description. > > It's not just what they are called, but how many too. Is 1 clock in > the DT valid? 0? It would be unusual for a given piece of h/w to > function with a variable number of clocks. Hi Rob The orion5x has 0 clocks. kirkwood, dove, Armada XP, 370 375, 380 has 1 clock. Armada 37xx has 4. So yes, 1 clock is valid. 0 clocks is also valid. The piece of hardware itself does not care how many clocks are feeding it, so long as they are all turned on. Andrew
diff --git a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt index 42cd81090a2c..3f3cfc1d8d4d 100644 --- a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt +++ b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt @@ -16,7 +16,7 @@ Required properties: Optional properties: - interrupts: interrupt line number for the SMI error/done interrupt -- clocks: phandle for up to three required clocks for the MDIO instance +- clocks: phandle for up to four required clocks for the MDIO instance The child nodes of the MDIO driver are the individual PHY devices connected to this MDIO bus. They must have a "reg" property given the