Message ID | 20190619181715.253903-1-nhuck@google.com |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | [v2] net: mvpp2: debugfs: Add pmap to fs dump | expand |
On Wed, Jun 19, 2019 at 11:17 AM 'Nathan Huckleberry' via Clang Built Linux <clang-built-linux@googlegroups.com> wrote: > > There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops' > Added a usage consistent with other fops to dump pmap > to userspace. > Changes from v1 -> v2 > * Fix typo > * Change commit prefix to debugfs Compile- Tested-by: Nick Desaulniers <ndesaulniers@google.com> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Requires `make ... W=1` before the patch to observe the warning. > drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c > index 0ee39ea47b6b..274fb07362cb 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c > @@ -566,6 +566,9 @@ static int mvpp2_dbgfs_prs_entry_init(struct dentry *parent, > debugfs_create_file("hits", 0444, prs_entry_dir, entry, > &mvpp2_dbgfs_prs_hits_fops); > > + debugfs_create_file("pmap", 0444, prs_entry_dir, entry, > + &mvpp2_dbgfs_prs_pmap_fops); > + Thanks, ~Nick Desaulniers
From: Nathan Huckleberry <nhuck@google.com> Date: Wed, 19 Jun 2019 11:17:15 -0700 > There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops' > Added a usage consistent with other fops to dump pmap > to userspace. > > Cc: clang-built-linux@googlegroups.com > Link: https://github.com/ClangBuiltLinux/linux/issues/529 > Signed-off-by: Nathan Huckleberry <nhuck@google.com> Applied.
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c index 0ee39ea47b6b..274fb07362cb 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c @@ -566,6 +566,9 @@ static int mvpp2_dbgfs_prs_entry_init(struct dentry *parent, debugfs_create_file("hits", 0444, prs_entry_dir, entry, &mvpp2_dbgfs_prs_hits_fops); + debugfs_create_file("pmap", 0444, prs_entry_dir, entry, + &mvpp2_dbgfs_prs_pmap_fops); + return 0; }
There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops' Added a usage consistent with other fops to dump pmap to userspace. Cc: clang-built-linux@googlegroups.com Link: https://github.com/ClangBuiltLinux/linux/issues/529 Signed-off-by: Nathan Huckleberry <nhuck@google.com> --- Changes from v1 -> v2 * Fix typo * Change commit prefix to debugfs drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c | 3 +++ 1 file changed, 3 insertions(+)