diff mbox series

[next] net/mlx5: add missing void argument to function mlx5_devlink_alloc

Message ID 20190618151510.18672-1-colin.king@canonical.com
State Accepted
Delegated to: David Miller
Headers show
Series [next] net/mlx5: add missing void argument to function mlx5_devlink_alloc | expand

Commit Message

Colin Ian King June 18, 2019, 3:15 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Function mlx5_devlink_alloc is missing a void argument, add it
to clean up the non-ANSI function declaration.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Saeed Mahameed June 18, 2019, 7:02 p.m. UTC | #1 
On Tue, 2019-06-18 at 16:15 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Function mlx5_devlink_alloc is missing a void argument, add it
> to clean up the non-ANSI function declaration.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> index ed4202e883f0..1533c657220b 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> @@ -37,7 +37,7 @@ static const struct devlink_ops mlx5_devlink_ops =
> {
>  	.flash_update = mlx5_devlink_flash_update,
>  };
>  
> -struct devlink *mlx5_devlink_alloc()
> +struct devlink *mlx5_devlink_alloc(void)
>  {
>  	return devlink_alloc(&mlx5_devlink_ops, sizeof(struct
> mlx5_core_dev));
>  }

Acked-by: Saeed Mahameed <saeedm@mellanox.com>

Dave, this one can go to net-next.

Thanks,
Saeed.
David Miller June 19, 2019, 2:30 a.m. UTC | #2 
From: Colin King <colin.king@canonical.com>
Date: Tue, 18 Jun 2019 16:15:10 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> Function mlx5_devlink_alloc is missing a void argument, add it
> to clean up the non-ANSI function declaration.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
index ed4202e883f0..1533c657220b 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
@@ -37,7 +37,7 @@  static const struct devlink_ops mlx5_devlink_ops = {
 	.flash_update = mlx5_devlink_flash_update,
 };
 
-struct devlink *mlx5_devlink_alloc()
+struct devlink *mlx5_devlink_alloc(void)
 {
 	return devlink_alloc(&mlx5_devlink_ops, sizeof(struct mlx5_core_dev));
 }