Message ID | 20190618142244.16463-1-colin.king@canonical.com |
---|---|
State | Awaiting Upstream |
Delegated to: | David Miller |
Headers | show |
Series | [V2,next] netfilter: synproxy: ensure zero is returned on non-error return path | expand |
On Tue, Jun 18, 2019 at 03:22:44PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently functions nf_synproxy_{ipc4|ipv6}_init return an uninitialized > garbage value in variable ret on a successful return. Fix this by > returning zero on success. Applied, thanks Colin.
diff --git a/net/netfilter/nf_synproxy_core.c b/net/netfilter/nf_synproxy_core.c index 50677285f82e..7bf5202e3222 100644 --- a/net/netfilter/nf_synproxy_core.c +++ b/net/netfilter/nf_synproxy_core.c @@ -798,7 +798,7 @@ int nf_synproxy_ipv4_init(struct synproxy_net *snet, struct net *net) } snet->hook_ref4++; - return err; + return 0; } EXPORT_SYMBOL_GPL(nf_synproxy_ipv4_init); @@ -1223,7 +1223,7 @@ nf_synproxy_ipv6_init(struct synproxy_net *snet, struct net *net) } snet->hook_ref6++; - return err; + return 0; } EXPORT_SYMBOL_GPL(nf_synproxy_ipv6_init);