| Message ID | 20190613161205.2689-1-vladbu@mellanox.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: sched: ingress: set 'unlocked' flag for clsact Qdisc ops | expand |
From: Vlad Buslov <vladbu@mellanox.com> Date: Thu, 13 Jun 2019 19:12:05 +0300 > To remove rtnl lock dependency in tc filter update API when using clsact > Qdisc, set QDISC_CLASS_OPS_DOIT_UNLOCKED flag in clsact Qdisc_class_ops. > > Clsact Qdisc ops don't require any modifications to be used without rtnl > lock on tc filter update path. Implementation never changes its q->block > and only releases it when Qdisc is being destroyed. This means it is enough > for RTM_{NEWTFILTER|DELTFILTER|GETTFILTER} message handlers to hold clsact > Qdisc reference while using it without relying on rtnl lock protection. > Unlocked Qdisc ops support is already implemented in filter update path by > unlocked cls API patch set. > > Signed-off-by: Vlad Buslov <vladbu@mellanox.com> Applied.
diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c index d5382554e281..599730f804d7 100644 --- a/net/sched/sch_ingress.c +++ b/net/sched/sch_ingress.c @@ -247,6 +247,7 @@ static void clsact_destroy(struct Qdisc *sch) } static const struct Qdisc_class_ops clsact_class_ops = { + .flags = QDISC_CLASS_OPS_DOIT_UNLOCKED, .leaf = ingress_leaf, .find = clsact_find, .walk = ingress_walk,
To remove rtnl lock dependency in tc filter update API when using clsact Qdisc, set QDISC_CLASS_OPS_DOIT_UNLOCKED flag in clsact Qdisc_class_ops. Clsact Qdisc ops don't require any modifications to be used without rtnl lock on tc filter update path. Implementation never changes its q->block and only releases it when Qdisc is being destroyed. This means it is enough for RTM_{NEWTFILTER|DELTFILTER|GETTFILTER} message handlers to hold clsact Qdisc reference while using it without relying on rtnl lock protection. Unlocked Qdisc ops support is already implemented in filter update path by unlocked cls API patch set. Signed-off-by: Vlad Buslov <vladbu@mellanox.com> --- net/sched/sch_ingress.c | 1 + 1 file changed, 1 insertion(+)