| Message ID | 20190612095037.6472-1-mcroce@redhat.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] mpls: fix af_mpls dependencies for real | expand |
From: Matteo Croce <mcroce@redhat.com> Date: Wed, 12 Jun 2019 11:50:37 +0200 > Randy reported that selecting MPLS_ROUTING without PROC_FS breaks > the build, because since commit c1a9d65954c6 ("mpls: fix af_mpls > dependencies"), MPLS_ROUTING selects PROC_SYSCTL, but Kconfig's select > doesn't recursively handle dependencies. > Change the select into a dependency. > > Fixes: c1a9d65954c6 ("mpls: fix af_mpls dependencies") > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Matteo Croce <mcroce@redhat.com> Applied.
diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig index 2b802a48d5a6..d1ad69b7942a 100644 --- a/net/mpls/Kconfig +++ b/net/mpls/Kconfig @@ -26,7 +26,7 @@ config NET_MPLS_GSO config MPLS_ROUTING tristate "MPLS: routing support" depends on NET_IP_TUNNEL || NET_IP_TUNNEL=n - select PROC_SYSCTL + depends on PROC_SYSCTL ---help--- Add support for forwarding of mpls packets.
Randy reported that selecting MPLS_ROUTING without PROC_FS breaks the build, because since commit c1a9d65954c6 ("mpls: fix af_mpls dependencies"), MPLS_ROUTING selects PROC_SYSCTL, but Kconfig's select doesn't recursively handle dependencies. Change the select into a dependency. Fixes: c1a9d65954c6 ("mpls: fix af_mpls dependencies") Reported-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Matteo Croce <mcroce@redhat.com> --- net/mpls/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)