| Message ID | 20190610032108.5791-2-yangbo.lu@nxp.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | Reuse ptp_qoriq driver for dpaa2-ptp | expand |
On Mon, Jun 10, 2019 at 11:21:03AM +0800, Yangbo Lu wrote: > This patch is to add QorIQ PTP support for DPAA2. > Although dpaa2-ptp.c driver is a fsl_mc_driver which > is using MC APIs for register accessing, it's same > IP block with eTSEC/DPAA/ENETC 1588 timer. We will > convert to reuse ptp_qoriq driver by using register > ioremap and dropping related MC APIs. > > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> > --- > drivers/ptp/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig > index 9b8fee5..b1b454f 100644 > --- a/drivers/ptp/Kconfig > +++ b/drivers/ptp/Kconfig > @@ -44,7 +44,7 @@ config PTP_1588_CLOCK_DTE > > config PTP_1588_CLOCK_QORIQ > tristate "Freescale QorIQ 1588 timer as PTP clock" > - depends on GIANFAR || FSL_DPAA_ETH || FSL_ENETC || FSL_ENETC_VF > + depends on GIANFAR || FSL_DPAA_ETH || FSL_DPAA2_ETH || FSL_ENETC || FSL_ENETC_VF > depends on PTP_1588_CLOCK Hi Yangbo Could COMPILE_TEST also be added? Thanks Andrew
Hi Andrew, > -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: 2019年6月10日 21:06 > To: Y.b. Lu <yangbo.lu@nxp.com> > Cc: netdev@vger.kernel.org; David S . Miller <davem@davemloft.net>; > Richard Cochran <richardcochran@gmail.com>; Rob Herring > <robh+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH 1/6] ptp: add QorIQ PTP support for DPAA2 > > On Mon, Jun 10, 2019 at 11:21:03AM +0800, Yangbo Lu wrote: > > This patch is to add QorIQ PTP support for DPAA2. > > Although dpaa2-ptp.c driver is a fsl_mc_driver which is using MC APIs > > for register accessing, it's same IP block with eTSEC/DPAA/ENETC 1588 > > timer. We will convert to reuse ptp_qoriq driver by using register > > ioremap and dropping related MC APIs. > > > > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> > > --- > > drivers/ptp/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig index > > 9b8fee5..b1b454f 100644 > > --- a/drivers/ptp/Kconfig > > +++ b/drivers/ptp/Kconfig > > @@ -44,7 +44,7 @@ config PTP_1588_CLOCK_DTE > > > > config PTP_1588_CLOCK_QORIQ > > tristate "Freescale QorIQ 1588 timer as PTP clock" > > - depends on GIANFAR || FSL_DPAA_ETH || FSL_ENETC || FSL_ENETC_VF > > + depends on GIANFAR || FSL_DPAA_ETH || FSL_DPAA2_ETH || > FSL_ENETC || > > +FSL_ENETC_VF > > depends on PTP_1588_CLOCK > > Hi Yangbo > > Could COMPILE_TEST also be added? [Y.b. Lu] COMPILE_TEST is usually for other ARCHs build coverage. Do you want me to append it after these Ethernet driver dependencies? Thanks. > > Thanks > Andrew
> > > diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig index > > > 9b8fee5..b1b454f 100644 > > > --- a/drivers/ptp/Kconfig > > > +++ b/drivers/ptp/Kconfig > > > @@ -44,7 +44,7 @@ config PTP_1588_CLOCK_DTE > > > > > > config PTP_1588_CLOCK_QORIQ > > > tristate "Freescale QorIQ 1588 timer as PTP clock" > > > - depends on GIANFAR || FSL_DPAA_ETH || FSL_ENETC || FSL_ENETC_VF > > > + depends on GIANFAR || FSL_DPAA_ETH || FSL_DPAA2_ETH || > > FSL_ENETC || > > > +FSL_ENETC_VF > > > depends on PTP_1588_CLOCK > > > > Hi Yangbo > > > > Could COMPILE_TEST also be added? > > [Y.b. Lu] COMPILE_TEST is usually for other ARCHs build coverage. > Do you want me to append it after these Ethernet driver dependencies? Hii Y.b. Lu Normally, drivers like this should be able to compile independent of the MAC driver. So you should be able to add COMPILE_TEST here. Andrew
> -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: 2019年6月12日 21:11 > To: Y.b. Lu <yangbo.lu@nxp.com> > Cc: netdev@vger.kernel.org; David S . Miller <davem@davemloft.net>; > Richard Cochran <richardcochran@gmail.com>; Rob Herring > <robh+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH 1/6] ptp: add QorIQ PTP support for DPAA2 > > > > > diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig index > > > > 9b8fee5..b1b454f 100644 > > > > --- a/drivers/ptp/Kconfig > > > > +++ b/drivers/ptp/Kconfig > > > > @@ -44,7 +44,7 @@ config PTP_1588_CLOCK_DTE > > > > > > > > config PTP_1588_CLOCK_QORIQ > > > > tristate "Freescale QorIQ 1588 timer as PTP clock" > > > > - depends on GIANFAR || FSL_DPAA_ETH || FSL_ENETC || > FSL_ENETC_VF > > > > + depends on GIANFAR || FSL_DPAA_ETH || FSL_DPAA2_ETH || > > > FSL_ENETC || > > > > +FSL_ENETC_VF > > > > depends on PTP_1588_CLOCK > > > > > > Hi Yangbo > > > > > > Could COMPILE_TEST also be added? > > > > [Y.b. Lu] COMPILE_TEST is usually for other ARCHs build coverage. > > Do you want me to append it after these Ethernet driver dependencies? > > Hii Y.b. Lu > > Normally, drivers like this should be able to compile independent of the MAC > driver. So you should be able to add COMPILE_TEST here. [Y.b. Lu] Thanks Andrew. I had sent out v2 with the change. > > Andrew
diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig index 9b8fee5..b1b454f 100644 --- a/drivers/ptp/Kconfig +++ b/drivers/ptp/Kconfig @@ -44,7 +44,7 @@ config PTP_1588_CLOCK_DTE config PTP_1588_CLOCK_QORIQ tristate "Freescale QorIQ 1588 timer as PTP clock" - depends on GIANFAR || FSL_DPAA_ETH || FSL_ENETC || FSL_ENETC_VF + depends on GIANFAR || FSL_DPAA_ETH || FSL_DPAA2_ETH || FSL_ENETC || FSL_ENETC_VF depends on PTP_1588_CLOCK default y help
This patch is to add QorIQ PTP support for DPAA2. Although dpaa2-ptp.c driver is a fsl_mc_driver which is using MC APIs for register accessing, it's same IP block with eTSEC/DPAA/ENETC 1588 timer. We will convert to reuse ptp_qoriq driver by using register ioremap and dropping related MC APIs. Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> --- drivers/ptp/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)