From patchwork Tue May 28 18:47:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 1106490 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="uurnpCfs"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45D2sN6YkYz9s00 for ; Wed, 29 May 2019 04:47:52 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728238AbfE1Srv (ORCPT ); Tue, 28 May 2019 14:47:51 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:41359 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728230AbfE1Sru (ORCPT ); Tue, 28 May 2019 14:47:50 -0400 Received: by mail-pf1-f194.google.com with SMTP id q17so7183017pfq.8 for ; Tue, 28 May 2019 11:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jW23EVTaONU8fGl2rO/gh8exrFRja4BdXSBKXyg60v0=; b=uurnpCfsYtTcOD+DDoo5/vvROcC25DPkJZQVnOHa1NtI+Y6CdsSZ18Jv0TzrpPV2M4 RizCON6yrAu71UY9bjyfxW/OSZCszU5Z/Mc3qMd1fAdIOZg7Z22XzJFxHKhCYMcpUsIV XftRLJs192LBdmYKLdJRVINTMeeo0DruiEz40QHbXnAsJhVPcoOL6KfpGT5BI/0s0u19 7UIABKC9gP2BX55+S2FpM82c3I0BoWAUstiXoi3nVp6I0iPkzy1vBrWVMJ8t9nT4WtMA HZUxjSWSeVBQbuisIm4dX5dPs8pMuPNJbHcXwNn8wfrf+xwRD6rOLi1AdqTdaqUcblEy S8Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jW23EVTaONU8fGl2rO/gh8exrFRja4BdXSBKXyg60v0=; b=tfzGlWp4sNtK6J9tjDkdvNGBXzPLrfaMSnGme0zhECo6hLa8449UQ1MIUh2tEIvKhf UmdoY1yaQegfg8gFPy0P9aboI6qirnh0mMhoayc2VNxfUtL12N/yRI3DBLqHgCMHVyxI DY0Y0OesZCfNUM3zqS5Z7pa8UW/jBuERChTPbhtJZSeYGFi0ri22d8l9YgpwavyDoXuM kzs6v3U91nlmK+IM6GIKteKUBHL9wzk0IhrKdjPmnySqiPyiO2AA7ln83PZ4+MECtNvA E9JQFjlcW3emjLyo36q7nAINonqyRUFVNpBel5zseTBvvN6zYLYAEaEhJiz0wo5lvInU Og0g== X-Gm-Message-State: APjAAAXLzpqml7f8c7uH09nRCXvJn3Hw2UioDHgvFNKlE5YQNZmZR8m1 ZWsG2ajC9pLmYBsSKoLbm0FrpQ== X-Google-Smtp-Source: APXvYqy8fD6xjAOYZRBAhKNbtsp/4z1yBh/JvX0ohy5Hx7W/1qso4HPAiE3tLai2iVeCXys7xYS3Kg== X-Received: by 2002:a63:b1d:: with SMTP id 29mr134329271pgl.103.1559069269408; Tue, 28 May 2019 11:47:49 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n12sm14213608pgq.54.2019.05.28.11.47.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 May 2019 11:47:48 -0700 (PDT) From: Stephen Hemminger X-Google-Original-From: Stephen Hemminger To: davem@davemloft.net, saeedm@mellanox.com, jasowang@redhat.com, brouer@redhat.com Cc: netdev@vger.kernel.org, xdp-newbies@vger.kernel.org, Stephen Hemminger Subject: [PATCH PATCH v4 1/2] netvsc: unshare skb in VF rx handler Date: Tue, 28 May 2019 11:47:30 -0700 Message-Id: <20190528184731.7464-2-sthemmin@microsoft.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190528184731.7464-1-sthemmin@microsoft.com> References: <20190528184731.7464-1-sthemmin@microsoft.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The netvsc VF skb handler should make sure that skb is not shared. Similar logic already exists in bonding and team device drivers. This is not an issue in practice because the VF devicex does not send up shared skb's. But the netvsc driver should do the right thing if it did. Fixes: 0c195567a8f6 ("netvsc: transparent VF management") Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 06393b215102..9873b8679f81 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -2000,6 +2000,12 @@ static rx_handler_result_t netvsc_vf_handle_frame(struct sk_buff **pskb) struct netvsc_vf_pcpu_stats *pcpu_stats = this_cpu_ptr(ndev_ctx->vf_stats); + skb = skb_share_check(skb, GFP_ATOMIC); + if (unlikely(!skb)) + return RX_HANDLER_CONSUMED; + + *pskb = skb; + skb->dev = ndev; u64_stats_update_begin(&pcpu_stats->syncp);