| Message ID | 20190509031341.31428-1-hancheng2009@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | dwmac4_prog_mtl_tx_algorithms() missing write operation | expand |
From: Cheng Han <hancheng2009@gmail.com> Date: Thu, 9 May 2019 11:13:41 +0800 > net: ethernet: stmmac: dwmac4_prog_mtl_tx_algorithms() missing write operation > > The value of MTL_OPERATION_MODE is not written back > > Signed-off-by: Cheng Han <hancheng2009@gmail.com> Good catch, applied, thanks.
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c index 7e5d5db..b4bb562 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c @@ -192,6 +192,8 @@ static void dwmac4_prog_mtl_tx_algorithms(struct mac_device_info *hw, default: break; } + + writel(value, ioaddr + MTL_OPERATION_MODE); } static void dwmac4_set_mtl_tx_queue_weight(struct mac_device_info *hw,
net: ethernet: stmmac: dwmac4_prog_mtl_tx_algorithms() missing write operation The value of MTL_OPERATION_MODE is not written back Signed-off-by: Cheng Han <hancheng2009@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 ++ 1 file changed, 2 insertions(+)