| Message ID | 20190503103628.17160-1-nicolas.ferre@microchip.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: macb: remove redundant struct phy_device declaration | expand |
On Fri, May 03, 2019 at 12:36:28PM +0200, Nicolas Ferre wrote: > While moving the chunk of code during 739de9a1563a > ("net: macb: Reorganize macb_mii bringup"), the declaration of > struct phy_device declaration was kept. It's not useful in this > function as we alrady have a phydev pointer. > > Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: Nicolas Ferre <nicolas.ferre@microchip.com> Date: Fri, 3 May 2019 12:36:28 +0200 > While moving the chunk of code during 739de9a1563a > ("net: macb: Reorganize macb_mii bringup"), the declaration of > struct phy_device declaration was kept. It's not useful in this > function as we alrady have a phydev pointer. > > Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com> Applied.
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 009ed4c1baf3..59531adcbb42 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -530,8 +530,6 @@ static int macb_mii_probe(struct net_device *dev) */ if (!bp->phy_node && !phy_find_first(bp->mii_bus)) { for (i = 0; i < PHY_MAX_ADDR; i++) { - struct phy_device *phydev; - phydev = mdiobus_scan(bp->mii_bus, i); if (IS_ERR(phydev) && PTR_ERR(phydev) != -ENODEV) {
While moving the chunk of code during 739de9a1563a ("net: macb: Reorganize macb_mii bringup"), the declaration of struct phy_device declaration was kept. It's not useful in this function as we alrady have a phydev pointer. Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com> --- drivers/net/ethernet/cadence/macb_main.c | 2 -- 1 file changed, 2 deletions(-)