| Message ID | 20190430112840.43452-1-yuehaibing@huawei.com |
|---|---|
| State | Superseded |
| Delegated to: | David Miller |
| Headers | show |
| Series | appletalk: Set error code while register_snap_client | expand |
patch title need fix, Pls ignore this. On 2019/4/30 19:28, YueHaibing wrote: > If register_snap_client fails in atalk_init, > error code should be set, otherwise it will > triggers NULL pointer dereference while unloading > module. > > Fixes: 9804501fa122 ("appletalk: Fix potential NULL pointer dereference in unregister_snap_client") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > net/appletalk/ddp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c > index 709d254..dbe8b19 100644 > --- a/net/appletalk/ddp.c > +++ b/net/appletalk/ddp.c > @@ -1920,6 +1920,7 @@ static int __init atalk_init(void) > ddp_dl = register_snap_client(ddp_snap_id, atalk_rcv); > if (!ddp_dl) { > pr_crit("Unable to register DDP with SNAP.\n"); > + rc = -ENOMEM; > goto out_sock; > } > >
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 709d254..dbe8b19 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -1920,6 +1920,7 @@ static int __init atalk_init(void) ddp_dl = register_snap_client(ddp_snap_id, atalk_rcv); if (!ddp_dl) { pr_crit("Unable to register DDP with SNAP.\n"); + rc = -ENOMEM; goto out_sock; }
If register_snap_client fails in atalk_init, error code should be set, otherwise it will triggers NULL pointer dereference while unloading module. Fixes: 9804501fa122 ("appletalk: Fix potential NULL pointer dereference in unregister_snap_client") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- net/appletalk/ddp.c | 1 + 1 file changed, 1 insertion(+)