| Message ID | 20190424201853.115414-1-marcel@holtmann.org |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | genetlink: use idr_alloc_cyclic for family->id assignment | expand |
From: Marcel Holtmann <marcel@holtmann.org> Date: Wed, 24 Apr 2019 22:18:53 +0200 > When allocating the next family->id it makes more sense to use > idr_alloc_cyclic to avoid re-using a previously used family->id as much > as possible. > > Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Applied, thanks Marcel.
diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index 288456090710..f1f2cbd7874e 100644 --- a/net/netlink/genetlink.c +++ b/net/netlink/genetlink.c @@ -362,8 +362,8 @@ int genl_register_family(struct genl_family *family) } else family->attrbuf = NULL; - family->id = idr_alloc(&genl_fam_idr, family, - start, end + 1, GFP_KERNEL); + family->id = idr_alloc_cyclic(&genl_fam_idr, family, + start, end + 1, GFP_KERNEL); if (family->id < 0) { err = family->id; goto errout_free;
When allocating the next family->id it makes more sense to use idr_alloc_cyclic to avoid re-using a previously used family->id as much as possible. Signed-off-by: Marcel Holtmann <marcel@holtmann.org> --- net/netlink/genetlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)