From patchwork Wed Apr 24 01:43:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tao Ren X-Patchwork-Id: 1089852 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=fb.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=fb.com header.i=@fb.com header.b="bPKt8oBS"; dkim=pass (1024-bit key; unprotected) header.d=fb.onmicrosoft.com header.i=@fb.onmicrosoft.com header.b="bo40wxxL"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44pjlk6ywhz9s3Z for ; Wed, 24 Apr 2019 11:44:02 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729306AbfDXBn5 (ORCPT ); Tue, 23 Apr 2019 21:43:57 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:43646 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726958AbfDXBn4 (ORCPT ); Tue, 23 Apr 2019 21:43:56 -0400 Received: from pps.filterd (m0044008.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3O1hVrY001203; Tue, 23 Apr 2019 18:43:36 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=facebook; bh=EoBC2YYQEdiCYLgEjsrY1Ma8fce70PkHJPD3rdyfwPU=; b=bPKt8oBSyGHjKtzvvlgaKTr9ZhPzMHKXI16tSFqADo5iZa9LlyaT0NZxX4x9jzJdNa4A I/HrK5mw21VpzX9McFXWZBUEtloVfezeK4mDJXXVVTsc8ANvSh2U18DOl7Hpar/A9TiB 7/K1U/ESKGPsDPpxxawjr9i91/zvvLThX/c= Received: from mail.thefacebook.com (mailout.thefacebook.com [199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 2s2dkxr4hg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2019 18:43:36 -0700 Received: from prn-mbx04.TheFacebook.com (2620:10d:c081:6::18) by prn-hub04.TheFacebook.com (2620:10d:c081:35::128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1713.5; Tue, 23 Apr 2019 18:43:36 -0700 Received: from prn-hub03.TheFacebook.com (2620:10d:c081:35::127) by prn-mbx04.TheFacebook.com (2620:10d:c081:6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1713.5; Tue, 23 Apr 2019 18:43:35 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (192.168.54.28) by o365-in.thefacebook.com (192.168.16.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1713.5 via Frontend Transport; Tue, 23 Apr 2019 18:43:35 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EoBC2YYQEdiCYLgEjsrY1Ma8fce70PkHJPD3rdyfwPU=; b=bo40wxxLN/Vw2FrSaybc3CEhLyhRcU7/D8b76aphtAKK2Tre1mYAwtYfH8n2P4JJD5TL+C9UyRLPAQViM10Z7lSQTQPWhoC3yqQv1C3x8h7TWyVpVfbLJCT1SJrDdnZ/oxdm0WcUCiZndfZuS2KJL5TWaG3vAbSMBCWl/sOHYkw= Received: from MWHPR15MB1216.namprd15.prod.outlook.com (10.175.2.146) by MWHPR15MB1583.namprd15.prod.outlook.com (10.173.235.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.12; Wed, 24 Apr 2019 01:43:32 +0000 Received: from MWHPR15MB1216.namprd15.prod.outlook.com ([fe80::9ccc:f6fa:40e2:f1cd]) by MWHPR15MB1216.namprd15.prod.outlook.com ([fe80::9ccc:f6fa:40e2:f1cd%10]) with mapi id 15.20.1813.017; Wed, 24 Apr 2019 01:43:32 +0000 From: Tao Ren To: "David S . Miller" , Maxim Mikityanskiy , Bartosz Golaszewski , Samuel Mendoza-Jonas , Jakub Kicinski , Joel Stanley , Andrew Jeffery , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "openbmc@lists.ozlabs.org" CC: Tao Ren Subject: [PATCH net v4] net/ncsi: handle overflow when incrementing mac address Thread-Topic: [PATCH net v4] net/ncsi: handle overflow when incrementing mac address Thread-Index: AQHU+j8fb/NadFiWqkOTQghGXrE+GQ== Date: Wed, 24 Apr 2019 01:43:32 +0000 Message-ID: <20190424014310.24253-1-taoren@fb.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MWHPR03CA0029.namprd03.prod.outlook.com (2603:10b6:301:3b::18) To MWHPR15MB1216.namprd15.prod.outlook.com (2603:10b6:320:23::18) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [2620:10d:c090:200::5189] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d6f28ace-00a5-4db9-1f66-08d6c8564227 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:MWHPR15MB1583; x-ms-traffictypediagnostic: MWHPR15MB1583: x-microsoft-antispam-prvs: x-forefront-prvs: 00179089FD x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(136003)(346002)(366004)(396003)(39860400002)(189003)(199004)(64756008)(52116002)(97736004)(316002)(6486002)(14454004)(99286004)(6436002)(110136005)(486006)(8676002)(5660300002)(53936002)(305945005)(7736002)(2616005)(476003)(81166006)(81156014)(6512007)(1076003)(8936002)(46003)(7416002)(36756003)(6506007)(2906002)(386003)(6116002)(25786009)(50226002)(71190400001)(71200400001)(102836004)(4326008)(478600001)(186003)(256004)(14444005)(86362001)(73956011)(66446008)(68736007)(66946007)(2201001)(66476007)(2501003)(66556008)(921003)(1121003); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR15MB1583; H:MWHPR15MB1216.namprd15.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: fb.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: pGdFyqX0FszlMoWNwda97bHndhx1ASAlxC0mybhRN2d8qsnCIsNy5TmmyPnjnT6m6cI5LBYIvumdFYAus4CiQ4xYRTHyYwXdcGkDlJ8fiGRAA/0veYac2mAizIeIoDcc0x2oHNGv2rg7Ndz+Y7Vhzjtb80cVuMcWaeI+yqkrchm2wW9/bWvPdXtzwcP9zm22Kgi/q7FRjciIDGL85fD7Le8ZybepDzeqmTgIgDYKveHdweaaX4O6yW0eMDBqzMExCY6FeR/4onwtWqOQ4V4O84LXAE23hHPT8ZXk3FmTpxmhZosUwmLMHGGd+zONTD0jY3HrVh5Nl5MGqh5zfnweGZg1EITXKlbzvW/3nH93m6hctMIJQUX9xYh+AJkNbuL3XvVkW3esv+S88GKsmcFHfPn/3fq3FNHTDlmJi2NwQxI= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d6f28ace-00a5-4db9-1f66-08d6c8564227 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2019 01:43:32.6950 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1583 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-24_01:, , signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Previously BMC's MAC address is calculated by simply adding 1 to the last byte of network controller's MAC address, and it produces incorrect result when network controller's MAC address ends with 0xFF. The problem can be fixed by calling eth_addr_inc() function to increment MAC address; besides, the MAC address is also validated before assigning to BMC. Fixes: cb10c7c0dfd9 ("net/ncsi: Add NCSI Broadcom OEM command") Signed-off-by: Tao Ren Acked-by: Jakub Kicinski Acked-by: Samuel Mendoza-Jonas --- include/linux/etherdevice.h | 12 ++++++++++++ net/ncsi/ncsi-rsp.c | 6 +++++- 2 files changed, 17 insertions(+), 1 deletion(-) Changes in v4: - revert the changes in eth_addr_dec() function comment. Changes in v3: - squash changes in "etherdevice.h" into this patch. - fix format issue in function comment. Changes in v2: - increment MAC address by calling eth_addr_inc() function. - validate MAC address before assigning to BMC. diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h index e2f3b21cd72a..aa8bfd6f738c 100644 --- a/include/linux/etherdevice.h +++ b/include/linux/etherdevice.h @@ -448,6 +448,18 @@ static inline void eth_addr_dec(u8 *addr) u64_to_ether_addr(u, addr); } +/** + * eth_addr_inc() - Increment the given MAC address. + * @addr: Pointer to a six-byte array containing Ethernet address to increment. + */ +static inline void eth_addr_inc(u8 *addr) +{ + u64 u = ether_addr_to_u64(addr); + + u++; + u64_to_ether_addr(u, addr); +} + /** * is_etherdev_addr - Tell if given Ethernet address belongs to the device. * @dev: Pointer to a device structure diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c index dc07fcc7938e..802db01e3075 100644 --- a/net/ncsi/ncsi-rsp.c +++ b/net/ncsi/ncsi-rsp.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include @@ -667,7 +668,10 @@ static int ncsi_rsp_handler_oem_bcm_gma(struct ncsi_request *nr) ndev->priv_flags |= IFF_LIVE_ADDR_CHANGE; memcpy(saddr.sa_data, &rsp->data[BCM_MAC_ADDR_OFFSET], ETH_ALEN); /* Increase mac address by 1 for BMC's address */ - saddr.sa_data[ETH_ALEN - 1]++; + eth_addr_inc((u8 *)saddr.sa_data); + if (!is_valid_ether_addr((const u8 *)saddr.sa_data)) + return -ENXIO; + ret = ops->ndo_set_mac_address(ndev, &saddr); if (ret < 0) netdev_warn(ndev, "NCSI: 'Writing mac address to device failed\n");