diff mbox series

[net-next,RFC,1/8] net: use kfree_skb_list() from ip_do_fragment()

Message ID 20190403154001.8177-2-pablo@netfilter.org
State RFC
Delegated to: David Miller
Headers show
Series connection tracking support for bridge | expand

Commit Message

Pablo Neira Ayuso April 3, 2019, 3:39 p.m. UTC 
Just like 46cfd725c377 ("net: use kfree_skb_list() helper in more places").

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 net/ipv4/ip_output.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

Florian Westphal April 4, 2019, 10:13 a.m. UTC | #1 
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> Just like 46cfd725c377 ("net: use kfree_skb_list() helper in more places").

Acked-by: Florian Westphal <fw@strlen.de>

Please consider submitting this as-is as standalone patch.
diff mbox series

Patch

diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index c80188875f39..10b35328cfbc 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -693,11 +693,8 @@  int ip_do_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
 			return 0;
 		}
 
-		while (frag) {
-			skb = frag->next;
-			kfree_skb(frag);
-			frag = skb;
-		}
+		kfree_skb_list(frag);
+
 		IP_INC_STATS(net, IPSTATS_MIB_FRAGFAILS);
 		return err;