diff mbox series

[net-next,v3,12/12] net: devlink: add warning for ndo_get_port_parent_id set when not needed

Message ID 20190402081512.2988-13-jiri@resnulli.us
State Superseded
Delegated to: David Miller
Headers show
Series net: extend devlink port attrs with switch ID | expand

Commit Message

Jiri Pirko April 2, 2019, 8:15 a.m. UTC 
From: Jiri Pirko <jiri@mellanox.com>

Currently if the driver registers devlink port instance, he should set
the devlink port attributes as well. Then the devlink core is able to
obtain switch id itself, no need for driver to implement the ndo.
Once all drivers will implement devlink port registration, this ndo
should be removed. This warning guides new drivers to do things as
they should be done.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
rfc->v1:
- new patch
---
 net/core/devlink.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/net/core/devlink.c b/net/core/devlink.c
index d9fbf94ea2a3..7b9eb14d4ea9 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -5376,6 +5376,7 @@  void devlink_port_type_eth_set(struct devlink_port *devlink_port,
 		err = ops->ndo_get_phys_port_name(netdev, name, sizeof(name));
 		WARN_ON(err != -EOPNOTSUPP);
 	}
+	WARN_ON(netdev->netdev_ops->ndo_get_port_parent_id);
 	__devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_ETH, netdev);
 }
 EXPORT_SYMBOL_GPL(devlink_port_type_eth_set);