| Message ID | 20190402050756.20507-1-jmaxwell37@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] tg3: allow ethtool -p to work for NICs in down state | expand |
On Mon, Apr 1, 2019 at 10:09 PM Jon Maxwell <jmaxwell37@gmail.com> wrote: > > Make tg3 behave like other drivers and let "ethtool -p" identify the > NIC even when it's in the DOWN state. Before this patch it would get an > error as follows if the NIC was down: > > # ip link set down dev em4 > # ethtool -p em4 > Cannot identify NIC: Resource temporarily unavailable > > With this patch ethtool identify works regardless of whether the NIC is up > or down as it does for other drivers. > > Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com> Acked-by: Michael Chan <michael.chan@broadcom.com> We used to power down the chip in tg3_close() and that's why we cannot do ethtool -p after close. We don't do that any more so this is fine. Thanks.
From: Jon Maxwell <jmaxwell37@gmail.com> Date: Tue, 2 Apr 2019 16:07:56 +1100 > Make tg3 behave like other drivers and let "ethtool -p" identify the > NIC even when it's in the DOWN state. Before this patch it would get an > error as follows if the NIC was down: > > # ip link set down dev em4 > # ethtool -p em4 > Cannot identify NIC: Resource temporarily unavailable > > With this patch ethtool identify works regardless of whether the NIC is up > or down as it does for other drivers. > > Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com> Applied, thanks Jon.
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 328373e0578f..3e458394f149 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -12763,9 +12763,6 @@ static int tg3_set_phys_id(struct net_device *dev, { struct tg3 *tp = netdev_priv(dev); - if (!netif_running(tp->dev)) - return -EAGAIN; - switch (state) { case ETHTOOL_ID_ACTIVE: return 1; /* cycle on/off once per second */
Make tg3 behave like other drivers and let "ethtool -p" identify the NIC even when it's in the DOWN state. Before this patch it would get an error as follows if the NIC was down: # ip link set down dev em4 # ethtool -p em4 Cannot identify NIC: Resource temporarily unavailable With this patch ethtool identify works regardless of whether the NIC is up or down as it does for other drivers. Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com> --- drivers/net/ethernet/broadcom/tg3.c | 3 --- 1 file changed, 3 deletions(-)