diff mbox series

[net-next,v2,01/12] net: devlink: convert devlink_port_attrs bools to bits

Message ID 20190401094026.3676-2-jiri@resnulli.us
State Changes Requested
Delegated to: David Miller
Headers show
Series net: extend devlink port attrs with switch ID | expand

Commit Message

Jiri Pirko April 1, 2019, 9:40 a.m. UTC 
From: Jiri Pirko <jiri@mellanox.com>

In order to save space in the struct, convert bools to bits.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
 include/net/devlink.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jakub Kicinski April 1, 2019, 6:39 p.m. UTC | #1 
On Mon,  1 Apr 2019 11:40:15 +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
> 
> In order to save space in the struct, convert bools to bits.
> 
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
diff mbox series

Patch

diff --git a/include/net/devlink.h b/include/net/devlink.h
index 31d5cec4d06b..4a1e3452a4ce 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -41,10 +41,10 @@  struct devlink {
 };
 
 struct devlink_port_attrs {
-	bool set;
+	u8 set:1,
+	   split:1;
 	enum devlink_port_flavour flavour;
 	u32 port_number; /* same value as "split group" */
-	bool split;
 	u32 split_subport_number;
 };