From patchwork Mon Apr 1 09:40:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 1072556 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="kJxBKoRb"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44XnQM5rMXz9sQt for ; Mon, 1 Apr 2019 20:40:43 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726451AbfDAJkm (ORCPT ); Mon, 1 Apr 2019 05:40:42 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:38888 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726756AbfDAJkl (ORCPT ); Mon, 1 Apr 2019 05:40:41 -0400 Received: by mail-wr1-f65.google.com with SMTP id k11so11089235wro.5 for ; Mon, 01 Apr 2019 02:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ogDnWRoAhi3J0+nF0MZgt/CN2InxRZfBSu5JCLVeAzo=; b=kJxBKoRbtCogW/E09r5WFAfg7sigc3GSqAmE7bvoQDf5tbHkGZ63onfn7ospU+NP63 7wbJykHHlivUZ7rI/vVtGVfKjZPv/7bCPO2jI1g54sS7NAlPzk89K5E9quUJD143Tf03 gqblwTYH9x54YSp3TEVT9zAxEi+6TvOthLlVJXL9Hf48tkOGt4zb3jUBOjQClWatXuSw 4AXKFhL3vgfAt2sypG0BlBEnvbWSxMlhBMcOUN0c+4BBccSzhOspb0nZdr7M7iDKk4j2 jfo6rex940VujBOjXjD2uvJaTbcBYsqH+zuzrQjXaMhpELCqOCC5LGcIZvkRKl3Jf0Ar 4Frw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ogDnWRoAhi3J0+nF0MZgt/CN2InxRZfBSu5JCLVeAzo=; b=TkX+FSywVivx9/p41snBImR8qCfblmYHL4eE8uIbLnWb/2i8b/ltIyWn56vk5QaF88 /RY7WwA4PRAy8kXSmhZLUs16agJ8dXZjXIO8T2Z8VRjsFhe5OlnPZCD5Ywgs0/6fhBVe 7iq+aPBkijF/6NmC5OndqAhGQmgDqXeYjxQO0p2s5OZzaV+WVf/725xtDUHAHsgyh2R8 rv9/SK2TO3prrtqaGeroxDWwNh2Mut8QuznPSAtqjm3ASVmcTwpoFtbvW2ol8ghJheR3 /0lHli2eOEDvm1ZY3pmgwqVSbrAdSaCi8Gwk/8GC95sv6QTJH1mUDgZnskTJnYeexuPT Bsrw== X-Gm-Message-State: APjAAAXZL2tBU1DKKTXz+TtedsvY05zOXCWSxJAVW/DkgaHkonpnNrrI BI2/2iV+6itCZJjRzym8Wf9Li8Egjt4= X-Google-Smtp-Source: APXvYqztkWtn1M1kvlO0Ix6eq/rwrVq3OS4YEnqb5bJfJM/nnx0x/LBHfIGR6EOjU5ajJ3pgenYqIQ== X-Received: by 2002:a5d:6883:: with SMTP id h3mr39372484wru.215.1554111639299; Mon, 01 Apr 2019 02:40:39 -0700 (PDT) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id a11sm9752651wrx.5.2019.04.01.02.40.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Apr 2019 02:40:39 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, michael.chan@broadcom.com Subject: [patch net-next v2 12/12] net: devlink: add warning for ndo_get_port_parent_id set when not needed Date: Mon, 1 Apr 2019 11:40:26 +0200 Message-Id: <20190401094026.3676-13-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190401094026.3676-1-jiri@resnulli.us> References: <20190401094026.3676-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Currently if the driver registers devlink port instance, he should set the devlink port attributes as well. Then the devlink core is able to obtain switch id itself, no need for driver to implement the ndo. Once all drivers will implement devlink port registration, this ndo should be removed. This warning guides new drivers to do things as they should be done. Signed-off-by: Jiri Pirko --- rfc->v1: - new patch --- net/core/devlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/devlink.c b/net/core/devlink.c index d9fbf94ea2a3..7b9eb14d4ea9 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -5376,6 +5376,7 @@ void devlink_port_type_eth_set(struct devlink_port *devlink_port, err = ops->ndo_get_phys_port_name(netdev, name, sizeof(name)); WARN_ON(err != -EOPNOTSUPP); } + WARN_ON(netdev->netdev_ops->ndo_get_port_parent_id); __devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_ETH, netdev); } EXPORT_SYMBOL_GPL(devlink_port_type_eth_set);