From patchwork Wed Mar 27 15:19:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 1067118 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="Ik+kMHot"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44TsBg18t3z9sPp for ; Thu, 28 Mar 2019 02:20:27 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731647AbfC0PUN (ORCPT ); Wed, 27 Mar 2019 11:20:13 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:40947 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731584AbfC0PUK (ORCPT ); Wed, 27 Mar 2019 11:20:10 -0400 Received: by mail-wm1-f65.google.com with SMTP id z24so477481wmi.5 for ; Wed, 27 Mar 2019 08:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TD+Ok/bxAY2v4xJCh5srLIcTX6P5QrnsXSeHjvIwPdU=; b=Ik+kMHotvhPpzKAIF06kqatkvxSTvK+Y5OmfFDSQFe1khBDozi2YIU/OftmiG2bFp5 9ExI6jUlkmgywV6+Shyu0n/6vgRuUigQ3bLDbXenZnswFdd0pV3B2zcSMFiqKUeyT7FQ oamaTjchjQ280/iJpHFH+GNa9ImJflPz3qPzTkNplFZXdDMi14hmJ+ZDFTP5P+KZ91a3 3kQ59CmZpJzKBTZ6Zm6ATORahQo6CRBpXHWnjebVES/AixS/b58UXsHk+UL95i3v1Sjs zjLqpToaDr0YVo6MpHR19XL1ws2j8ws3kMvElGLi8uFdODE+RFyxngpXGf1xBtacVpW3 iWPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TD+Ok/bxAY2v4xJCh5srLIcTX6P5QrnsXSeHjvIwPdU=; b=nTNZWyLURVSWugyhfXehecGVbdTbH7/97B4fi0Uasnp7JoNbT5i8G87Z3OdWlW2u3r 4O0virF0A3jFKsnyc7+eaJbJ8/sZCVpZvYakg2J10aDi1rBqNPR9DaEDuEbhZjOuyKsg dVWnZ27rZPqQ+VkXwGkW8lDppbBu9oxDHFcsS7hYqVkcA9IQPY9RXwtCNumCEzTrbu75 yXAwg5O0uhFN3xdk+RZ2f6dQJXeHJ962QYm8pZ2jum+lcPh+aSxIRz/jAQaMS69wd1w2 iD7NSBs5TgLGqjVHDB32P00SUlxPgqsD0CdZS1HJJkdKiUdlX1oOrKtO51Ni6+oBd3sT U8rw== X-Gm-Message-State: APjAAAWZWeSFR6i0UaadXWkxWiWMNxPqQDLYzrqbfT2UBK0acgndJaRr UW+fSoJR6Ojd71/VY3DBeaFVe5paQRY= X-Google-Smtp-Source: APXvYqyLORR5RUNA2etHlOM5bKEhd74jBLt+yZsN1N3pUJrfS2GjrUPw3OUXvUtbomWiMmdl973O5Q== X-Received: by 2002:a1c:e0d6:: with SMTP id x205mr17725219wmg.28.1553700008683; Wed, 27 Mar 2019 08:20:08 -0700 (PDT) Received: from localhost (ip-94-113-223-73.net.upcbroadband.cz. [94.113.223.73]) by smtp.gmail.com with ESMTPSA id s16sm8751698wrw.58.2019.03.27.08.20.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Mar 2019 08:20:08 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, michael.chan@broadcom.com Subject: [patch net-next v3 08/12] bnxt: remove ndo_get_phys_port_name implementation Date: Wed, 27 Mar 2019 16:19:54 +0100 Message-Id: <20190327151958.2649-9-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190327151958.2649-1-jiri@resnulli.us> References: <20190327151958.2649-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Rely on the previously introduced fallback and let the core call devlink in order to get the physical port name. Signed-off-by: Jiri Pirko --- v1->v2: - new patch --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index eca36cac594e..35e34e23ba33 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -10048,23 +10048,6 @@ static int bnxt_bridge_setlink(struct net_device *dev, struct nlmsghdr *nlh, return rc; } -static int bnxt_get_phys_port_name(struct net_device *dev, char *buf, - size_t len) -{ - struct bnxt *bp = netdev_priv(dev); - int rc; - - /* The PF and it's VF-reps only support the switchdev framework */ - if (!BNXT_PF(bp)) - return -EOPNOTSUPP; - - rc = snprintf(buf, len, "p%d", bp->pf.port_id); - - if (rc >= len) - return -EOPNOTSUPP; - return 0; -} - int bnxt_get_port_parent_id(struct net_device *dev, struct netdev_phys_item_id *ppid) { @@ -10122,7 +10105,6 @@ static const struct net_device_ops bnxt_netdev_ops = { .ndo_bridge_getlink = bnxt_bridge_getlink, .ndo_bridge_setlink = bnxt_bridge_setlink, .ndo_get_port_parent_id = bnxt_get_port_parent_id, - .ndo_get_phys_port_name = bnxt_get_phys_port_name, .ndo_get_devlink_port = bnxt_get_devlink_port, };