From patchwork Tue Mar 12 07:59:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kangjie Lu X-Patchwork-Id: 1055120 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=umn.edu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=umn.edu header.i=@umn.edu header.b="Ch9vuvjy"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44JS7R2LJYz9s7h for ; Tue, 12 Mar 2019 19:00:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbfCLIAB (ORCPT ); Tue, 12 Mar 2019 04:00:01 -0400 Received: from mta-p5.oit.umn.edu ([134.84.196.205]:50880 "EHLO mta-p5.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726218AbfCLH75 (ORCPT ); Tue, 12 Mar 2019 03:59:57 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p5.oit.umn.edu (Postfix) with ESMTP id E0C1BA8F for ; Tue, 12 Mar 2019 07:59:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p5.oit.umn.edu ([127.0.0.1]) by localhost (mta-p5.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s9H5PaJmU3eJ for ; Tue, 12 Mar 2019 02:59:55 -0500 (CDT) Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p5.oit.umn.edu (Postfix) with ESMTPS id AB44AA32 for ; Tue, 12 Mar 2019 02:59:55 -0500 (CDT) Received: by mail-io1-f70.google.com with SMTP id v3so1239845iol.3 for ; Tue, 12 Mar 2019 00:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=1nkZcVU0GvUzDc/ZYNTpuRtHlao+2b0Vm1VZH2b1N8U=; b=Ch9vuvjydJ4EhQPIcG7puULxC+JRbV5Chpg2PLSeQh+EyWOBrybWR1/nJNODcDbxaI PQskGTtnLDWIo5/AU/BTCwwMJnVQgJs3ekRvPcMXx9Pp984XlFYGe7ufnX/NcpnSoEor UorOHxgCM15q/CNDL8doF8cO90EcjUkKKvp+pmPW36YpXU7aK0nB1MOgA+u6Z8i4gMZn XjmF4beVRrUNsqrgPHlNdEt3BVcTXDjYdAjqBsVNp7sxXBsHUXYnqQFn5cNQPRmM3rlM snfDcGx7lXb78OO0gkXQ/5Yi3ibqv00LObONxyBOn9Ul81VHh61U4k69iGjjy3XnLsIC EwnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1nkZcVU0GvUzDc/ZYNTpuRtHlao+2b0Vm1VZH2b1N8U=; b=k3yJp15qGT83PM58kaAP1+okbtI8Z2+XaMAWzmNHiNeWLyXRNxvzuAK5YJGfY+lO/X Fo4FFgFYHJDvHKnve2n1P4eJyWP1lvi/xnp+Qvfpz3dQKjeCJnKKieDXF5HR+/xtq0nT z9s8KAQZqMEpFfmqavnQq0aUfKDS/sDSskshCMBxnnYV+DSCt/J6K5yyjthTym4/SAk0 BoYWsxnVgBKVQ+FpqdCfWLWt6nB+dQc9suMZFg7eUQh7V0Em3j/tNRvQ1CLuvLBZDk0t 8Mrw8xaAhzMWDFmF8IuJzxgXWAK/x6TPmgVH4QG5DyW8eRQ5HR82zYc6Hgd6caYqLIph IwDw== X-Gm-Message-State: APjAAAWnnZX+jr5jvf1N3dUPTsmLKq3/43OGh/n6BRH38qPOKpoCJi4p UeipRAybnmCZQsJyuQuzTNXACKZrgvxPcAxPRzky0LY7dtq1F5rKQSd4w9YMC2ZfPb9BsOiNqus C0L0g1IUSEoBPiFGgd6jg X-Received: by 2002:a02:4083:: with SMTP id n125mr21568219jaa.63.1552377595298; Tue, 12 Mar 2019 00:59:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqyOfP+9mqD+1XLGDv4RfFO3LOxcYkCR4RoLYjEACGFPQr+ni9W5LMOCuUKOkpHRPxMIwUeagA== X-Received: by 2002:a02:4083:: with SMTP id n125mr21568200jaa.63.1552377595059; Tue, 12 Mar 2019 00:59:55 -0700 (PDT) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id u12sm3391365iop.77.2019.03.12.00.59.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2019 00:59:54 -0700 (PDT) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Ping-Ke Shih , Kalle Valo , "David S. Miller" , Larry Finger , Andrew Morton , Ingo Molnar , Randy Dunlap , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: rtl8192c: fix a potential NULL pointer dereference Date: Tue, 12 Mar 2019 02:59:46 -0500 Message-Id: <20190312075948.1569-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In case dev_alloc_skb fails, the fix safely returns to avoid potential NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/net/wireless/realtek/rtlwifi/rtl8192c/fw_common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/fw_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/fw_common.c index 18c76990a089..9042fc044c7e 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/fw_common.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/fw_common.c @@ -623,6 +623,9 @@ void rtl92c_set_fw_rsvdpagepkt(struct ieee80211_hw *hw, u1rsvdpageloc, 3); skb = dev_alloc_skb(totalpacketlen); + if (!skb) + return; + skb_put_data(skb, &reserved_page_packet, totalpacketlen); if (cmd_send_packet)