From patchwork Sat Mar 9 03:31:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kangjie Lu X-Patchwork-Id: 1053790 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=umn.edu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=umn.edu header.i=@umn.edu header.b="bkPoAYtc"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44GVMk6gYzz9s70 for ; Sat, 9 Mar 2019 14:33:54 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726571AbfCIDcF (ORCPT ); Fri, 8 Mar 2019 22:32:05 -0500 Received: from mta-p6.oit.umn.edu ([134.84.196.206]:33568 "EHLO mta-p6.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726392AbfCIDcE (ORCPT ); Fri, 8 Mar 2019 22:32:04 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p6.oit.umn.edu (Postfix) with ESMTP id 9F9F9D81 for ; Sat, 9 Mar 2019 03:32:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p6.oit.umn.edu ([127.0.0.1]) by localhost (mta-p6.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qM7qtU9_H_gg for ; Fri, 8 Mar 2019 21:32:02 -0600 (CST) Received: from mail-it1-f198.google.com (mail-it1-f198.google.com [209.85.166.198]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p6.oit.umn.edu (Postfix) with ESMTPS id 7CBB1D33 for ; Fri, 8 Mar 2019 21:32:02 -0600 (CST) Received: by mail-it1-f198.google.com with SMTP id x87so8236941ita.1 for ; Fri, 08 Mar 2019 19:32:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=tVwmnqvwoAFICf/1Dr09ZnF/dcwXmtrlc3FFHeFeNQ0=; b=bkPoAYtcz/IDTnQe0OUboWzLF+b6PHsadLO1qc44d2f5fglBM8kxGA4eu8yqzfjVvh FXoiGUvhmuN6nwP51p7RsWAmTAPhhGPCgBllMiu9fLSjdrWWU+jbKn/ukBVmHVAKzpTi q6iNMLu2e5J3AkEhz6isjoPeNIg4kRTdu8qUG8CCRp3iDJXsWae8J3clsq2WRD0NMbFz fIbsxt571iuPRXhKIfFREVee+QE14w6XuTYs0F2xebGCWRZ4PI5BD6odHT6XrSWbtRdb oM4KhVQyaoJXlE424u9iiAQqm4UycsQlRVzodNb65ablHW63rpa+xG8OVWft/tMG9oqX sfUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tVwmnqvwoAFICf/1Dr09ZnF/dcwXmtrlc3FFHeFeNQ0=; b=lxJatIfrdcmxYTOvl03jOhU7LJLwafCmgg3+6yiwt48BYKWxIfHM+hJrx8IcyhpwC4 0GvgpZPNmXFrwZ2RrLnc8kGV6iFowRPgzd/Ik1TH/sW7MlkofqVFuiqHjZpa+z/b6SWv 8jpBfgj244ofKSowtiVJjIV//N67exoU7kdxUBTg1J9XhaNwjVgs5bp2vKyKijKHeiMI 2GUG3vPGPRzMog94LhEASFP0NtWl/AnGSoq4TjCvZROGYbGPWkGfIXGJuiCxQJYpsbZw IdgKuKgSWwh3jHt7QMNvTF0ND8im4kt2aVkZT5FW9tedFpf6LoCzobh9Sb6w2fV+jBNV CTgw== X-Gm-Message-State: APjAAAVV7sYtECV8rl6CDC6JFmmW5iPd7DBaQDnAq/g+Q+G2+nmvv9dl I5KwwyFD716rf+3kom+vidJKuBUqWQSDtWXoTBeK4lTF0fFVnaUNUrfWy7ZjIIpAxpJ/sYFkw+Z CX6QFq/glsUv+THgoH54c X-Received: by 2002:a24:4087:: with SMTP id n129mr9794258ita.140.1552102321734; Fri, 08 Mar 2019 19:32:01 -0800 (PST) X-Google-Smtp-Source: APXvYqxAVazD3IKzIoZ4AsIPxInjHCcxRHx8D8Gj6nPKptHsEcXQKtTr+xJ7xZ9WRv3eTpG8Q0Oi1g== X-Received: by 2002:a24:4087:: with SMTP id n129mr9794247ita.140.1552102321434; Fri, 08 Mar 2019 19:32:01 -0800 (PST) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id i26sm1751792ioj.86.2019.03.08.19.32.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 19:32:00 -0800 (PST) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Jeff Kirsher , "David S. Miller" , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack Date: Fri, 8 Mar 2019 21:31:23 -0600 Message-Id: <20190309033123.30001-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If ixgbevf_write_msg_read_ack fails, return its error code upstream Signed-off-by: Kangjie Lu Tested-by: Andrew Bowers --- drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c index cd3b81300cc7..d5ce49636548 100644 --- a/drivers/net/ethernet/intel/ixgbevf/vf.c +++ b/drivers/net/ethernet/intel/ixgbevf/vf.c @@ -508,9 +508,8 @@ static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw, vector_list[i++] = ixgbevf_mta_vector(hw, ha->addr); } - ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, IXGBE_VFMAILBOX_SIZE); - - return 0; + return ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, + IXGBE_VFMAILBOX_SIZE); } /**