| Message ID | 20190309033123.30001-1-kjlu@umn.edu |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack | expand |
> -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Kangjie Lu > Sent: Friday, March 8, 2019 7:31 PM > To: kjlu@umn.edu > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; intel-wired- > lan@lists.osuosl.org; pakki001@umn.edu; David S. Miller > <davem@davemloft.net> > Subject: [Intel-wired-lan] [PATCH] net: ixgbevf: fix a missing check of > ixgbevf_write_msg_read_ack > > If ixgbevf_write_msg_read_ack fails, return its error code upstream > > Signed-off-by: Kangjie Lu <kjlu@umn.edu> > --- > drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c index cd3b81300cc7..d5ce49636548 100644 --- a/drivers/net/ethernet/intel/ixgbevf/vf.c +++ b/drivers/net/ethernet/intel/ixgbevf/vf.c @@ -508,9 +508,8 @@ static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw, vector_list[i++] = ixgbevf_mta_vector(hw, ha->addr); } - ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, IXGBE_VFMAILBOX_SIZE); - - return 0; + return ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, + IXGBE_VFMAILBOX_SIZE); } /**
If ixgbevf_write_msg_read_ack fails, return its error code upstream Signed-off-by: Kangjie Lu <kjlu@umn.edu> --- drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)