[v6,perf,bpf,10/15] perf-top: add option --no-bpf-event

Message ID	20190306071359.2359896-11-songliubraving@fb.com
State	Awaiting Upstream
Delegated to:	BPF Maintainers
Headers	show Return-Path: <netdev-owner@vger.kernel.org> Smtp-Origin-Hostprefix: devbig From: Song Liu <songliubraving@fb.com> Smtp-Origin-Hostname: devbig006.ftw2.facebook.com To: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org> CC: <ast@kernel.org>, <daniel@iogearbox.net>, <kernel-team@fb.com>, <peterz@infradead.org>, <acme@redhat.com>, <jolsa@kernel.org>, <namhyung@kernel.org>, Song Liu <songliubraving@fb.com> Smtp-Origin-Cluster: ftw2c04 Subject: [PATCH v6 perf,bpf 10/15] perf-top: add option --no-bpf-event Date: Tue, 5 Mar 2019 23:13:54 -0800 Message-ID: <20190306071359.2359896-11-songliubraving@fb.com> In-Reply-To: <20190306071359.2359896-1-songliubraving@fb.com> References: <20190306071359.2359896-1-songliubraving@fb.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk
Series	perf annotation of BPF programs \| expand [v6,perf,bpf,00/15] perf annotation of BPF programs [v6,perf,bpf,01/15] perf, bpf: consider events with attr.bpf_event as side-band events [v6,perf,bpf,02/15] bpf: libbpf: introduce bpf_program__get_prog_info_linear() [v6,perf,bpf,03/15] bpf: bpftool: use bpf_program__get_prog_info_linear() in prog.c:do_dump() [v6,perf,bpf,04/15] perf, bpf: synthesize bpf events with bpf_program__get_prog_info_linear() [v6,perf,bpf,05/15] perf: change prototype of perf_event__synthesize_bpf_events() [v6,perf,bpf,06/15] perf, bpf: save bpf_prog_info in a rbtree in perf_env [v6,perf,bpf,07/15] perf, bpf: save bpf_prog_info information as headers to perf.data [v6,perf,bpf,08/15] perf, bpf: save btf in a rbtree in perf_env [v6,perf,bpf,09/15] perf, bpf: save btf information as headers to perf.data [v6,perf,bpf,10/15] perf-top: add option --no-bpf-event [v6,perf,bpf,11/15] perf: add -lopcodes to feature-libbfd [v6,perf,bpf,12/15] perf, bpf: enable annotation of bpf program [v6,perf,bpf,13/15] perf, bpf: process PERF_BPF_EVENT_PROG_LOAD for annotation [v6,perf,bpf,14/15] perf: introduce side band thread [v6,perf,bpf,15/15] perf, bpf: save bpf_prog_info and btf of short living bpf programs

Message ID

20190306071359.2359896-11-songliubraving@fb.com

State

Awaiting Upstream

Delegated to:

BPF Maintainers

Headers

Smtp-Origin-Hostprefix: devbig
From: Song Liu <songliubraving@fb.com>
Smtp-Origin-Hostname: devbig006.ftw2.facebook.com
To: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: <ast@kernel.org>, <daniel@iogearbox.net>, <kernel-team@fb.com>,
	<peterz@infradead.org>, <acme@redhat.com>, <jolsa@kernel.org>,
	<namhyung@kernel.org>, Song Liu <songliubraving@fb.com>
Smtp-Origin-Cluster: ftw2c04
Subject: [PATCH v6 perf,bpf 10/15] perf-top: add option --no-bpf-event
Date: Tue, 5 Mar 2019 23:13:54 -0800
Message-ID: <20190306071359.2359896-11-songliubraving@fb.com>
In-Reply-To: <20190306071359.2359896-1-songliubraving@fb.com>
References: <20190306071359.2359896-1-songliubraving@fb.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: netdev-owner@vger.kernel.org
Precedence: bulk

Series

perf annotation of BPF programs | expand

Commit Message

Song Liu March 6, 2019, 7:13 a.m. UTC

bpf events should be tracked by default for perf-top. This patch makes it
on by default, and adds option to disable bpf events.

Signed-off-by: Song Liu <songliubraving@fb.com>
---
 tools/perf/builtin-top.c | 3 +++
 tools/perf/util/top.h    | 1 +
 2 files changed, 4 insertions(+)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 27d8d42e0a4d..ccdf5689452f 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1492,6 +1492,7 @@  int cmd_top(int argc, const char **argv)
 		    "Display raw encoding of assembly instructions (default)"),
 	OPT_BOOLEAN(0, "demangle-kernel", &symbol_conf.demangle_kernel,
 		    "Enable kernel symbol demangling"),
+	OPT_BOOLEAN(0, "no-bpf-event", &top.no_bpf_event, "do not record bpf events"),
 	OPT_STRING(0, "objdump", &top.annotation_opts.objdump_path, "path",
 		    "objdump binary to use for disassembly and annotations"),
 	OPT_STRING('M', "disassembler-style", &top.annotation_opts.disassembler_style, "disassembler style",
@@ -1651,6 +1652,8 @@  int cmd_top(int argc, const char **argv)
 		signal(SIGWINCH, winch_sig);
 	}
 
+	top.record_opts.bpf_event = !top.no_bpf_event;
+
 	status = __cmd_top(&top);
 
 out_delete_evlist:
diff --git a/tools/perf/util/top.h b/tools/perf/util/top.h
index 19f95eaf75c8..862a37bd27ea 100644
--- a/tools/perf/util/top.h
+++ b/tools/perf/util/top.h
@@ -32,6 +32,7 @@  struct perf_top {
 	bool		   use_tui, use_stdio;
 	bool		   vmlinux_warned;
 	bool		   dump_symtab;
+	bool		   no_bpf_event;
 	struct hist_entry  *sym_filter_entry;
 	struct perf_evsel  *sym_evsel;
 	struct perf_session *session;

[v6,perf,bpf,10/15] perf-top: add option --no-bpf-event

Commit Message

Patch